Skip to content

Commit f257134

Browse files
committed
Update to elasticsearch 1.3.0
Related to #89. (cherry picked from commit 11e1d8a)
1 parent f470e34 commit f257134

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

src/test/java/org/elasticsearch/discovery/ec2/Ec2DiscoveryITest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import org.elasticsearch.cloud.aws.AbstractAwsTest;
2424
import org.elasticsearch.cloud.aws.AbstractAwsTest.AwsTest;
2525
import org.elasticsearch.common.settings.Settings;
26+
import org.elasticsearch.plugins.PluginsService;
2627
import org.elasticsearch.test.ElasticsearchIntegrationTest.ClusterScope;
2728
import org.elasticsearch.test.ElasticsearchIntegrationTest.Scope;
2829
import org.junit.Test;
@@ -35,16 +36,17 @@
3536
* This test requires AWS to run.
3637
*/
3738
@AwsTest
38-
@ClusterScope(scope = Scope.TEST, numDataNodes = 0)
39+
@ClusterScope(scope = Scope.TEST, numDataNodes = 0, numClientNodes = 0, transportClientRatio = 0.0)
3940
public class Ec2DiscoveryITest extends AbstractAwsTest {
4041

4142
@Test
4243
public void testStart() {
4344
Settings nodeSettings = settingsBuilder()
45+
.put("plugins." + PluginsService.LOAD_PLUGIN_FROM_CLASSPATH, true)
4446
.put("cloud.enabled", true)
4547
.put("discovery.type", "ec2")
4648
.build();
47-
cluster().startNode(nodeSettings);
49+
internalCluster().startNode(nodeSettings);
4850
}
4951

5052
}

src/test/java/org/elasticsearch/repositories/s3/S3SnapshotRestoreTest.java

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import org.elasticsearch.common.settings.ImmutableSettings;
3636
import org.elasticsearch.common.settings.Settings;
3737
import org.elasticsearch.common.util.concurrent.UncategorizedExecutionException;
38+
import org.elasticsearch.plugins.PluginsService;
3839
import org.elasticsearch.repositories.RepositoryMissingException;
3940
import org.elasticsearch.snapshots.SnapshotState;
4041
import org.elasticsearch.test.ElasticsearchIntegrationTest.ClusterScope;
@@ -53,7 +54,7 @@
5354
/**
5455
*/
5556
@AwsTest
56-
@ClusterScope(scope = Scope.SUITE, numDataNodes = 2)
57+
@ClusterScope(scope = Scope.SUITE, numDataNodes = 2, numClientNodes = 0, transportClientRatio = 0.0)
5758
public class S3SnapshotRestoreTest extends AbstractAwsTest {
5859

5960
@Override
@@ -64,6 +65,7 @@ public Settings indexSettings() {
6465
.put(MockDirectoryHelper.RANDOM_PREVENT_DOUBLE_WRITE, false)
6566
.put(MockDirectoryHelper.RANDOM_NO_DELETE_OPEN_FILE, false)
6667
.put("cloud.enabled", true)
68+
.put("plugins." + PluginsService.LOAD_PLUGIN_FROM_CLASSPATH, true)
6769
.build();
6870
}
6971

@@ -85,7 +87,7 @@ public final void wipeAfter() {
8587
@Test
8688
public void testSimpleWorkflow() {
8789
Client client = client();
88-
logger.info("--> creating s3 repository with bucket[{}] and path [{}]", cluster().getInstance(Settings.class).get("repositories.s3.bucket"), basePath);
90+
logger.info("--> creating s3 repository with bucket[{}] and path [{}]", internalCluster().getInstance(Settings.class).get("repositories.s3.bucket"), basePath);
8991
PutRepositoryResponse putRepositoryResponse = client.admin().cluster().preparePutRepository("test-repo")
9092
.setType("s3").setSettings(ImmutableSettings.settingsBuilder()
9193
.put("base_path", basePath)
@@ -157,7 +159,7 @@ public void testSimpleWorkflow() {
157159
@Test
158160
public void testEncryption() {
159161
Client client = client();
160-
logger.info("--> creating s3 repository with bucket[{}] and path [{}]", cluster().getInstance(Settings.class).get("repositories.s3.bucket"), basePath);
162+
logger.info("--> creating s3 repository with bucket[{}] and path [{}]", internalCluster().getInstance(Settings.class).get("repositories.s3.bucket"), basePath);
161163
PutRepositoryResponse putRepositoryResponse = client.admin().cluster().preparePutRepository("test-repo")
162164
.setType("s3").setSettings(ImmutableSettings.settingsBuilder()
163165
.put("base_path", basePath)
@@ -187,9 +189,9 @@ public void testEncryption() {
187189

188190
assertThat(client.admin().cluster().prepareGetSnapshots("test-repo").setSnapshots("test-snap").get().getSnapshots().get(0).state(), equalTo(SnapshotState.SUCCESS));
189191

190-
Settings settings = cluster().getInstance(Settings.class);
192+
Settings settings = internalCluster().getInstance(Settings.class);
191193
Settings bucket = settings.getByPrefix("repositories.s3.");
192-
AmazonS3 s3Client = cluster().getInstance(AwsS3Service.class).client(
194+
AmazonS3 s3Client = internalCluster().getInstance(AwsS3Service.class).client(
193195
bucket.get("region", settings.get("repositories.s3.region")),
194196
bucket.get("access_key", settings.get("cloud.aws.access_key")),
195197
bucket.get("secret_key", settings.get("cloud.aws.secret_key")));
@@ -248,7 +250,7 @@ public void testEncryption() {
248250
@Test(expected = UncategorizedExecutionException.class)
249251
public void assertRepositoryWithCustomCredentialsIsNotAccessibleByDefaultCredentials() {
250252
Client client = client();
251-
Settings bucketSettings = cluster().getInstance(Settings.class).getByPrefix("repositories.s3.private-bucket.");
253+
Settings bucketSettings = internalCluster().getInstance(Settings.class).getByPrefix("repositories.s3.private-bucket.");
252254
logger.info("--> creating s3 repository with bucket[{}] and path [{}]", bucketSettings.get("bucket"), basePath);
253255
PutRepositoryResponse putRepositoryResponse = client.admin().cluster().preparePutRepository("test-repo")
254256
.setType("s3").setSettings(ImmutableSettings.settingsBuilder()
@@ -263,7 +265,7 @@ public void assertRepositoryWithCustomCredentialsIsNotAccessibleByDefaultCredent
263265
@Test
264266
public void testRepositoryWithCustomCredentials() {
265267
Client client = client();
266-
Settings bucketSettings = cluster().getInstance(Settings.class).getByPrefix("repositories.s3.private-bucket.");
268+
Settings bucketSettings = internalCluster().getInstance(Settings.class).getByPrefix("repositories.s3.private-bucket.");
267269
logger.info("--> creating s3 repository with bucket[{}] and path [{}]", bucketSettings.get("bucket"), basePath);
268270
PutRepositoryResponse putRepositoryResponse = client.admin().cluster().preparePutRepository("test-repo")
269271
.setType("s3").setSettings(ImmutableSettings.settingsBuilder()
@@ -285,7 +287,7 @@ public void testRepositoryWithCustomCredentials() {
285287
@Test(expected = UncategorizedExecutionException.class)
286288
public void assertRepositoryInRemoteRegionIsRemote() {
287289
Client client = client();
288-
Settings bucketSettings = cluster().getInstance(Settings.class).getByPrefix("repositories.s3.remote-bucket.");
290+
Settings bucketSettings = internalCluster().getInstance(Settings.class).getByPrefix("repositories.s3.remote-bucket.");
289291
logger.info("--> creating s3 repository with bucket[{}] and path [{}]", bucketSettings.get("bucket"), basePath);
290292
PutRepositoryResponse putRepositoryResponse = client.admin().cluster().preparePutRepository("test-repo")
291293
.setType("s3").setSettings(ImmutableSettings.settingsBuilder()
@@ -302,7 +304,7 @@ public void assertRepositoryInRemoteRegionIsRemote() {
302304
@Test
303305
public void testRepositoryInRemoteRegion() {
304306
Client client = client();
305-
Settings settings = cluster().getInstance(Settings.class);
307+
Settings settings = internalCluster().getInstance(Settings.class);
306308
Settings bucketSettings = settings.getByPrefix("repositories.s3.remote-bucket.");
307309
logger.info("--> creating s3 repository with bucket[{}] and path [{}]", bucketSettings.get("bucket"), basePath);
308310
PutRepositoryResponse putRepositoryResponse = client.admin().cluster().preparePutRepository("test-repo")
@@ -374,7 +376,7 @@ public static void wipeRepositories(String... repositories) {
374376
* Deletes content of the repository files in the bucket
375377
*/
376378
public void cleanRepositoryFiles(String basePath) {
377-
Settings settings = cluster().getInstance(Settings.class);
379+
Settings settings = internalCluster().getInstance(Settings.class);
378380
Settings[] buckets = {
379381
settings.getByPrefix("repositories.s3."),
380382
settings.getByPrefix("repositories.s3.private-bucket."),
@@ -385,7 +387,7 @@ public void cleanRepositoryFiles(String basePath) {
385387
String accessKey = bucket.get("access_key", settings.get("cloud.aws.access_key"));
386388
String secretKey = bucket.get("secret_key", settings.get("cloud.aws.secret_key"));
387389
String bucketName = bucket.get("bucket");
388-
AmazonS3 client = cluster().getInstance(AwsS3Service.class).client(region, accessKey, secretKey);
390+
AmazonS3 client = internalCluster().getInstance(AwsS3Service.class).client(region, accessKey, secretKey);
389391
try {
390392
ObjectListing prevListing = null;
391393
//From http://docs.amazonwebservices.com/AmazonS3/latest/dev/DeletingMultipleObjectsUsingJava.html

0 commit comments

Comments
 (0)