Remove IndexFieldData#clear since it is unused. (#60475)

This method was never called. It also seemed tricky that calling a method on
`IndexFieldData` could clear the contents of a shared cache.

Author: jtibshirani

modules/mapper-extras/src/main/java/org/elasticsearch/index/mapper/ScaledFloatFieldMapper.java

@@ -541,11 +541,6 @@ protected boolean sortRequiresCustomComparator() {
             return true;
         }
 
-        @Override
-        public void clear() {
-            scaledFieldData.clear();
-        }
-
         @Override
         public NumericType getNumericType() {
             /*

server/src/main/java/org/elasticsearch/index/fielddata/IndexFieldData.java

@@ -86,11 +86,6 @@ public interface IndexFieldData<FD extends LeafFieldData> {
     BucketedSort newBucketedSort(BigArrays bigArrays, @Nullable Object missingValue, MultiValueMode sortMode,
             Nested nested, SortOrder sortOrder, DocValueFormat format, int bucketSize, BucketedSort.ExtraData extra);
 
-    /**
-     * Clears any resources associated with this field data.
-     */
-    void clear();
-
     // we need this extended source we we have custom comparators to reuse our field data
     // in this case, we need to reduce type that will be used when search results are reduced
     // on another node (we don't have the custom source them...)

server/src/main/java/org/elasticsearch/index/fielddata/IndexHistogramFieldData.java

@@ -44,8 +44,4 @@ public ValuesSourceType getValuesSourceType() {
         return valuesSourceType;
     }
 
-    @Override
-    public final void clear() {
-        // can't do
-    }
 }

server/src/main/java/org/elasticsearch/index/fielddata/ordinals/GlobalOrdinalsIndexFieldData.java

@@ -117,9 +117,6 @@ public BucketedSort newBucketedSort(BigArrays bigArrays, Object missingValue, Mu
         throw new IllegalArgumentException("only supported on numeric fields");
     }
 
-    @Override
-    public void clear() {}
-
     @Override
     public long ramBytesUsed() {
         return memorySizeInBytes;
@@ -211,9 +208,6 @@ public BucketedSort newBucketedSort(BigArrays bigArrays, Object missingValue, Mu
             throw new IllegalArgumentException("only supported on numeric fields");
         }
 
-        @Override
-        public void clear() {}
-
         @Override
         public long ramBytesUsed() {
             return memorySizeInBytes;

server/src/main/java/org/elasticsearch/index/fielddata/plain/AbstractIndexFieldData.java

@@ -58,11 +58,6 @@ public ValuesSourceType getValuesSourceType() {
         return valuesSourceType;
     }
 
-    @Override
-    public void clear() {
-        cache.clear(fieldName);
-    }
-
     @Override
     public FD load(LeafReaderContext context) {
         if (context.reader().getFieldInfos().fieldInfo(fieldName) == null) {

server/src/main/java/org/elasticsearch/index/fielddata/plain/AbstractLatLonPointIndexFieldData.java

@@ -59,11 +59,6 @@ public ValuesSourceType getValuesSourceType() {
         return valuesSourceType;
     }
 
-    @Override
-    public final void clear() {
-        // can't do
-    }
-
     @Override
     public SortField sortField(@Nullable Object missingValue, MultiValueMode sortMode, XFieldComparatorSource.Nested nested,
             boolean reverse) {

server/src/main/java/org/elasticsearch/index/fielddata/plain/BinaryIndexFieldData.java

@@ -69,10 +69,6 @@ public ValuesSourceType getValuesSourceType() {
         return valuesSourceType;
     }
 
-    @Override
-    public final void clear() {
-        // can't do
-    }
 
     @Override
     public BinaryDVLeafFieldData load(LeafReaderContext context) {

server/src/main/java/org/elasticsearch/index/fielddata/plain/BytesBinaryIndexFieldData.java

@@ -57,11 +57,6 @@ public ValuesSourceType getValuesSourceType() {
         return valuesSourceType;
     }
 
-    @Override
-    public final void clear() {
-        // can't do
-    }
-
     @Override
     public SortField sortField(@Nullable Object missingValue, MultiValueMode sortMode, Nested nested, boolean reverse) {
         throw new IllegalArgumentException("can't sort on binary field");

server/src/main/java/org/elasticsearch/index/fielddata/plain/ConstantIndexFieldData.java

@@ -146,10 +146,6 @@ private ConstantIndexFieldData(String name, String value, ValuesSourceType value
         atomicFieldData = new ConstantLeafFieldData(value);
     }
 
-    @Override
-    public void clear() {
-    }
-
     @Override
     public final LeafOrdinalsFieldData load(LeafReaderContext context) {
         return atomicFieldData;

server/src/main/java/org/elasticsearch/index/fielddata/plain/SortedNumericIndexFieldData.java

@@ -92,11 +92,6 @@ public ValuesSourceType getValuesSourceType() {
         return valuesSourceType;
     }
 
-    @Override
-    public final void clear() {
-        // can't do
-    }
-
     @Override
     protected boolean sortRequiresCustomComparator() {
         return numericType == NumericType.HALF_FLOAT;

server/src/main/java/org/elasticsearch/index/fielddata/plain/SortedSetOrdinalsIndexFieldData.java

@@ -109,11 +109,6 @@ public ValuesSourceType getValuesSourceType() {
         return valuesSourceType;
     }
 
-    @Override
-    public final void clear() {
-        // can't do
-    }
-
     @Override
     public SortField sortField(@Nullable Object missingValue, MultiValueMode sortMode, Nested nested, boolean reverse) {
         XFieldComparatorSource source = new BytesRefFieldComparatorSource(this, missingValue, sortMode, nested);

server/src/main/java/org/elasticsearch/index/fielddata/plain/StringBinaryIndexFieldData.java

@@ -54,26 +54,21 @@ public ValuesSourceType getValuesSourceType() {
         return valuesSourceType;
     }
 
-    @Override
-    public final void clear() {
-        // can't do
-    }
-    
     @Override
     public SortField sortField(Object missingValue, MultiValueMode sortMode, Nested nested, boolean reverse) {
         XFieldComparatorSource source = new BytesRefFieldComparatorSource(this, missingValue,
                 sortMode, nested);
         return new SortField(getFieldName(), source, reverse);
     }
-    
+
     @Override
     public StringBinaryDVLeafFieldData load(LeafReaderContext context) {
         try {
             return new StringBinaryDVLeafFieldData(DocValues.getBinary(context.reader(), fieldName));
         } catch (IOException e) {
             throw new IllegalStateException("Cannot load doc values", e);
         }
-    } 
+    }
     @Override
     public BucketedSort newBucketedSort(BigArrays bigArrays, Object missingValue, MultiValueMode sortMode, Nested nested,
             SortOrder sortOrder, DocValueFormat format, int bucketSize, BucketedSort.ExtraData extra) {

server/src/main/java/org/elasticsearch/index/mapper/IdFieldMapper.java

@@ -209,12 +209,6 @@ public BucketedSort newBucketedSort(BigArrays bigArrays, Object missingValue, Mu
                                 Nested nested, SortOrder sortOrder, DocValueFormat format, int bucketSize, BucketedSort.ExtraData extra) {
                             throw new UnsupportedOperationException("can't sort on the [" + CONTENT_TYPE + "] field");
                         }
-
-                        @Override
-                        public void clear() {
-                            fieldData.clear();
-                        }
-
                     };
                 }
             };

server/src/test/java/org/elasticsearch/index/fielddata/NoOrdinalsStringFieldDataTests.java

@@ -69,11 +69,6 @@ public BucketedSort newBucketedSort(BigArrays bigArrays, Object missingValue, Mu
                 throw new UnsupportedOperationException();
             }
 
-            @Override
-            public void clear() {
-                in.clear();
-            }
-
         };
     }
 

server/src/test/java/org/elasticsearch/index/query/functionscore/FunctionScoreTests.java

@@ -159,11 +159,6 @@ public BucketedSort newBucketedSort(BigArrays bigArrays, Object missingValue, Mu
                 SortOrder sortOrder, DocValueFormat format, int bucketSize, BucketedSort.ExtraData extra) {
             throw new UnsupportedOperationException(UNSUPPORTED);
         }
-
-        @Override
-        public void clear() {
-            throw new UnsupportedOperationException(UNSUPPORTED);
-        }
     }
 
     /**
@@ -249,11 +244,6 @@ public LeafNumericFieldData loadDirect(LeafReaderContext context) throws Excepti
         protected boolean sortRequiresCustomComparator() {
             return false;
         }
-
-        @Override
-        public void clear() {
-            throw new UnsupportedOperationException(UNSUPPORTED);
-        }
     }
 
     private static final ScoreFunction RANDOM_SCORE_FUNCTION = new RandomScoreFunction(0, 0, new IndexFieldDataStub());

x-pack/plugin/mapper-flattened/src/main/java/org/elasticsearch/xpack/flattened/mapper/FlatObjectFieldMapper.java

@@ -374,11 +374,6 @@ public BucketedSort newBucketedSort(BigArrays bigArrays, Object missingValue, Mu
             throw new IllegalArgumentException("only supported on numeric fields");
         }
 
-        @Override
-        public void clear() {
-            delegate.clear();
-        }
-
         @Override
         public LeafOrdinalsFieldData load(LeafReaderContext context) {
             LeafOrdinalsFieldData fieldData = delegate.load(context);

x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/index/fielddata/AbstractLatLonShapeIndexFieldData.java

@@ -42,11 +42,6 @@ public ValuesSourceType getValuesSourceType() {
         return valuesSourceType;
     }
 
-    @Override
-    public final void clear() {
-        // can't do
-    }
-
     @Override
     public SortField sortField(@Nullable Object missingValue, MultiValueMode sortMode, XFieldComparatorSource.Nested nested,
             boolean reverse) {

x-pack/plugin/vectors/src/main/java/org/elasticsearch/xpack/vectors/query/VectorIndexFieldData.java

@@ -43,11 +43,6 @@ public ValuesSourceType getValuesSourceType() {
         return valuesSourceType;
     }
 
-    @Override
-    public final void clear() {
-        // can't do
-    }
-
     @Override
     public SortField sortField(@Nullable Object missingValue, MultiValueMode sortMode, Nested nested, boolean reverse) {
         throw new IllegalArgumentException("can't sort on the vector field");