Skip to content

Commit f3cfd45

Browse files
committed
Use addIfAbsent instead of checking if an element is contained
Relates to #32988
1 parent 917e5a8 commit f3cfd45

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

server/src/main/java/org/elasticsearch/transport/ConnectionManager.java

+2-5
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import java.io.Closeable;
3939
import java.io.IOException;
4040
import java.util.Iterator;
41-
import java.util.List;
4241
import java.util.Map;
4342
import java.util.concurrent.ConcurrentMap;
4443
import java.util.concurrent.CopyOnWriteArrayList;
@@ -85,9 +84,7 @@ public ConnectionManager(Settings settings, Transport transport, ThreadPool thre
8584
}
8685

8786
public void addListener(TransportConnectionListener listener) {
88-
if (connectionListener.listeners.contains(listener) == false) {
89-
this.connectionListener.listeners.add(listener);
90-
}
87+
this.connectionListener.listeners.addIfAbsent(listener);
9188
}
9289

9390
public void removeListener(TransportConnectionListener listener) {
@@ -297,7 +294,7 @@ public void onFailure(Exception e) {
297294

298295
private static final class DelegatingNodeConnectionListener implements TransportConnectionListener {
299296

300-
private final List<TransportConnectionListener> listeners = new CopyOnWriteArrayList<>();
297+
private final CopyOnWriteArrayList<TransportConnectionListener> listeners = new CopyOnWriteArrayList<>();
301298

302299
@Override
303300
public void onNodeDisconnected(DiscoveryNode key) {

0 commit comments

Comments
 (0)