Skip to content

Commit f6933b4

Browse files
spoonnotfoundpugnascotia
authored andcommitted
Fix warning when installing a plugin for different ESversion (#66146)
This commit change the warn message returned by elasticsearch-plugin list. The elasticsearch version of plugin is needed for comparison with current es version rather than the plugin version.
1 parent 29f73d4 commit f6933b4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

distribution/tools/plugin-cli/src/main/java/org/elasticsearch/plugins/ListPluginsCommand.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ private void printPlugin(Environment env, Terminal terminal, Path plugin, String
7070
"WARNING: plugin ["
7171
+ info.getName()
7272
+ "] was built for Elasticsearch version "
73-
+ info.getVersion()
73+
+ info.getElasticsearchVersion()
7474
+ " but version "
7575
+ Version.CURRENT
7676
+ " is required"

distribution/tools/plugin-cli/src/test/java/org/elasticsearch/plugins/ListPluginsCommandTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ public void testExistingIncompatiblePlugin() throws Exception {
266266
buildFakePlugin(env, "fake desc 2", "fake_plugin2", "org.fake2");
267267

268268
MockTerminal terminal = listPlugins(home);
269-
String message = "plugin [fake_plugin1] was built for Elasticsearch version 1.0 but version " + Version.CURRENT + " is required";
269+
String message = "plugin [fake_plugin1] was built for Elasticsearch version 1.0.0 but version " + Version.CURRENT + " is required";
270270
assertEquals("fake_plugin1\nfake_plugin2\n", terminal.getOutput());
271271
assertEquals("WARNING: " + message + "\n", terminal.getErrorOutput());
272272

0 commit comments

Comments
 (0)