Skip to content

Commit f85dfc7

Browse files
EQL: Refine bwc version checks on EqlSearchRequest (#91510)
1 parent e715f3c commit f85dfc7

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

docs/changelog/91510.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
pr: 91510
2+
summary: Refine bwc version checks on `EqlSearchRequest`
3+
area: EQL
4+
type: bug
5+
issues: []

x-pack/plugin/eql/src/main/java/org/elasticsearch/xpack/eql/action/EqlSearchRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public EqlSearchRequest(StreamInput in) throws IOException {
118118
this.waitForCompletionTimeout = in.readOptionalTimeValue();
119119
this.keepAlive = in.readOptionalTimeValue();
120120
this.keepOnCompletion = in.readBoolean();
121-
if (in.getVersion().onOrAfter(Version.V_8_0_0)) {
121+
if (in.getVersion().onOrAfter(Version.V_7_17_8)) {
122122
resultPosition = in.readString();
123123
}
124124
if (in.getVersion().onOrAfter(Version.V_7_13_0)) {
@@ -436,7 +436,7 @@ public void writeTo(StreamOutput out) throws IOException {
436436
out.writeOptionalTimeValue(waitForCompletionTimeout);
437437
out.writeOptionalTimeValue(keepAlive);
438438
out.writeBoolean(keepOnCompletion);
439-
if (out.getVersion().onOrAfter(Version.V_8_0_0)) {
439+
if (out.getVersion().onOrAfter(Version.V_7_17_8)) {
440440
out.writeString(resultPosition);
441441
}
442442
if (out.getVersion().onOrAfter(Version.V_7_13_0)) {

x-pack/plugin/eql/src/test/java/org/elasticsearch/xpack/eql/action/EqlSearchRequestTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ protected EqlSearchRequest mutateInstanceForVersion(EqlSearchRequest instance, V
132132
mutatedInstance.keepOnCompletion(instance.keepOnCompletion());
133133
mutatedInstance.fetchFields(version.onOrAfter(Version.V_7_13_0) ? instance.fetchFields() : null);
134134
mutatedInstance.runtimeMappings(version.onOrAfter(Version.V_7_13_0) ? instance.runtimeMappings() : emptyMap());
135-
mutatedInstance.resultPosition(version.onOrAfter(Version.V_8_0_0) ? instance.resultPosition() : "tail");
135+
mutatedInstance.resultPosition(version.onOrAfter(Version.V_7_17_8) ? instance.resultPosition() : "tail");
136136

137137
return mutatedInstance;
138138
}

0 commit comments

Comments
 (0)