Skip to content

Commit fb67083

Browse files
committed
Add comment
1 parent d6fd1da commit fb67083

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

core/src/main/java/org/elasticsearch/index/engine/InternalEngine.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1917,6 +1917,11 @@ public void onFailure(Exception e) {
19171917

19181918
@Override
19191919
protected void doRun() throws Exception {
1920+
/*
1921+
* We do this on another thread rather than the merge thread that we are called on so that we have complete confidence
1922+
* that the call stack does not contain catch statements that would prevent the error that might be thrown here from
1923+
* being caught and never reaching the uncaught exception handler.
1924+
*/
19201925
maybeDie("fatal error while merging", exc);
19211926
logger.error("failed to merge", exc);
19221927
failEngine("merge failed", new MergePolicy.MergeException(exc, dir));

0 commit comments

Comments
 (0)