Skip to content

Update recommended template priority for override in documentation to 500 #115196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lahsivjar opened this issue Oct 21, 2024 · 3 comments · Fixed by #119450
Closed

Update recommended template priority for override in documentation to 500 #115196

lahsivjar opened this issue Oct 21, 2024 · 3 comments · Fixed by #119450
Assignees
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team

Comments

@lahsivjar
Copy link
Contributor

Description

APM team recently migrated to APM data plugin for managing our index templates, component templates, ingest pipelines, etc. As part of the change, we were forced to increase the priority of our index templates from 200 to 210 to override the fleet's priority. Fleet installs templates with a priority of either 150 or 200, documented to be anything between 100 and 200.

The current recommendation in https://www.elastic.co/guide/en/elasticsearch/reference/current/index-templates.html indicates to override with priority greater than 200 which won't work for APM cases now with our updated priority. I am proposing to increase the recommended priority number to 500 to give us enough room to make changes to managed templates when and if required.

There were similar changes made earlier to the doc in #68982.

@lahsivjar lahsivjar added >enhancement needs:triage Requires assignment of a team area label labels Oct 21, 2024
@endorama
Copy link
Member

Reading through previous work here and our current docs, an additional point is that #68982 already uses 500 as the value for all examples. Looking at the changes in #69006, the PR that closes the mentioned issue, is possible to see that 500 has been used as value.

The only place where 200 is used is in this phrase:

Assign templates with an overlapping pattern a priority higher than 200. For example, if you don’t use Fleet or Elastic Agent and want to create a template for the logs-* index pattern, assign your template a priority of 500. This ensures your template is applied instead of the built-in template for logs--.

@lahsivjar to confirm is what you expect to see 500 in place of 200 in the phrase above or am I missing something?

@lahsivjar
Copy link
Contributor Author

@lahsivjar to confirm is what you expect to see 500 in place of 200 in the phrase above or am I missing something?

Yeah. The examples use 500 but the actual statement suggests 200+, so that needs to be updated.

@gbanasiak gbanasiak added the :Data Management/Indices APIs APIs to create and manage indices and templates label Oct 23, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Oct 23, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants