Skip to content

Simplify reading sets, maps, and lists #13893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nik9000 opened this issue Oct 1, 2015 · 3 comments
Closed

Simplify reading sets, maps, and lists #13893

nik9000 opened this issue Oct 1, 2015 · 3 comments
Labels
:Core/Infra/Core Core issues without another label discuss >enhancement

Comments

@nik9000
Copy link
Member

nik9000 commented Oct 1, 2015

While working on removing ImmutableMap and ImmutableSet I've seen a ton of different fun ways to read immutable maps, sets, and lists. If we're willing to use Java 8's function pointer things we could remove lots of duplicated code by creating readMap, readSet, and readList in StreamInput. We could probably also do something similar for writing these but I haven't thought as much about it.
@jpountz
Copy link
Contributor

jpountz commented Oct 2, 2015

+1

@nik9000 nik9000 mentioned this issue Oct 13, 2015
Merged
@colings86 colings86 added >enhancement :Core/Infra/Core Core issues without another label labels Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@tomcallahan
Copy link
Contributor

Those methods exist, and we're unlikely to tie an issue to going on a large deduplication effort. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label discuss >enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@clintongormley @nik9000 @colings86 @jpountz @elasticmachine @tomcallahan