Skip to content

Ensure 6.x BWC compatibility when searching indices with nanosecond fields #38028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spinscale opened this issue Jan 30, 2019 · 3 comments
Closed
Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch team-discuss

Comments

@spinscale
Copy link
Contributor

Once #37755 is merged we need to ensure backwards compatibility.

With the current state of #37755 there would be no BWC compatiblity, as a 6.7 coordinating node would not know the difference. The sort field would be treated as a regular numeric field.

Also the 6.7 mapping code does not know what type: date_nanos is. I am not sure how a 6.7 would react here.

We could implement a simple safeguard like preventing index creation if the minimum node version is below 7 or we could port the nanosecond conversion logic to 6.7.0. Maybe there are more options that I am not seeing.

Also, this might impact current CCS refactorings.

@spinscale spinscale added blocker :Search Foundations/Mapping Index mappings, including merging and defining field types team-discuss v6.7.0 labels Jan 30, 2019
@jimczi
Copy link
Contributor

jimczi commented Jan 30, 2019

IMO this is a non-issue since you shouldn't have a nanosecond field in a cluster that is not fully migrated to 7x ?

@jpountz
Copy link
Contributor

jpountz commented Jan 30, 2019

Another option could be to document that sorting across date and nanoseconds fields is only a best-effort and only works if all data nodes are on 7.x and in the same cluster.

@spinscale spinscale removed the blocker label Feb 1, 2019
@spinscale
Copy link
Contributor Author

Closing for now as we decided to pursue another strategy with the nano fieldmapper.

@javanna javanna added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch team-discuss
Projects
None yet
Development

No branches or pull requests

5 participants