Skip to content

Hashing of access tokens values for storage #40765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkakavas opened this issue Apr 3, 2019 · 3 comments · Fixed by #41792
Closed

Hashing of access tokens values for storage #40765

jkakavas opened this issue Apr 3, 2019 · 3 comments · Fixed by #41792
Assignees
Labels
blocker :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v7.2.0 v8.0.0-alpha1

Comments

@jkakavas
Copy link
Member

jkakavas commented Apr 3, 2019

Since #39631 the access token string is part of the token document ID. We should move forward with the planned changes regarding the hashing of the access token string before it becomes part of the token document id in the same version also ( 7.1 ).
This is required so that potential read access to the token security index will not allow for authentication.

Relates: #37038 , #39631

@jkakavas jkakavas added blocker :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0 v7.2.0 labels Apr 3, 2019
@jkakavas jkakavas self-assigned this Apr 3, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@albertzaharovits
Copy link
Contributor

Refresh tokens also require hashing.

I assume you mean unsalted hashes, given that Access Tokens have a max lifetime of 1h and Refresh Tokens of 24h hours, and that these id are randomly generated with ~120 bits of entropy.

@jkakavas
Copy link
Member Author

jkakavas commented Apr 3, 2019

Refresh tokens also require hashing.

I assume you mean unsalted hashes,

Correct, this will be implemented as designed and described in the original email. The fact that these will be unsalted doesn't have to do with the lifetime of the tokens but only with the bits of entropy that makes the computation and storage of rainbow tables impossible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants