Skip to content

[CI] ShardSizeTermsIT.testNoShardSizeTermOrderDouble #43040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henningandersen opened this issue Jun 10, 2019 · 3 comments
Closed

[CI] ShardSizeTermsIT.testNoShardSizeTermOrderDouble #43040

henningandersen opened this issue Jun 10, 2019 · 3 comments
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI v8.0.0-alpha1

Comments

@henningandersen
Copy link
Contributor

henningandersen commented Jun 10, 2019

Failed on master once here:

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+g1gc/18/console

with:

java.lang.AssertionError: 
Expected: <8L>
     but: was <3L>
	at __randomizedtesting.SeedInfo.seed([F688A226AA20AF15:6341D5542888518A]:0)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
	at org.junit.Assert.assertThat(Assert.java:956)
	at org.junit.Assert.assertThat(Assert.java:923)
	at org.elasticsearch.search.aggregations.bucket.ShardSizeTermsIT.testNoShardSizeTermOrderDouble(ShardSizeTermsIT.java:379)

Reproduction line:

./gradlew :server:integTest --tests "org.elasticsearch.search.aggregations.bucket.ShardSizeTermsIT.testNoShardSizeTermOrderDouble" -Dtests.seed=F688A226AA20AF15 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:-UseConcMarkSweepGC -XX:+UseG1GC" -Dtests.locale=nl-NL -Dtests.timezone=SystemV/EST5EDT -Dcompiler.java=12 -Druntime.java=11

did not work out for me, neither did more extensive test running (1000+ runs).

Given that this only failed once, I left it unmuted in case further test failures could provide valuable input.

@henningandersen henningandersen added :Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI v8.0.0 labels Jun 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@polyfractal
Copy link
Contributor

Chatted briefly about this failure in weekly meeting. Haven't looked at it yet, but whenever we get to it we should probably add checks for shard failures. E.g. a shard failure would return partial results and fail assertions.

Probably applies to many such agg tests.

@talevy talevy self-assigned this Aug 21, 2019
@rjernst rjernst added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 4, 2020
@talevy talevy removed their assignment Mar 16, 2021
@csoulios
Copy link
Contributor

csoulios commented Apr 7, 2021

This test has not failed for more than 1 year (since February 7th 2020)
Also, related to #42893 the integration test will be replaced by an AggregatorTestCase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI v8.0.0-alpha1
Projects
None yet
Development

No branches or pull requests

7 participants