Skip to content

Rename ScriptFactory interface used to mark scripts deterministic #50379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stu-elastic opened this issue Dec 19, 2019 · 5 comments
Closed

Rename ScriptFactory interface used to mark scripts deterministic #50379

stu-elastic opened this issue Dec 19, 2019 · 5 comments
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring Team:Core/Infra Meta label for core/infra team

Comments

@stu-elastic
Copy link
Contributor

The ScriptFactory interface is poorly named, since as of #50344 it is no long a common base for all script factories.

We should rename it to something more appropriate to it's use, which is indicating determinism (and therefore result cacheability) of scripts.

Related: #49466
@stu-elastic stu-elastic added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring v8.0.0 v7.6.0 labels Dec 19, 2019
@stu-elastic stu-elastic self-assigned this Dec 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@stu-elastic stu-elastic mentioned this issue Dec 19, 2019
Merged
@polyfractal polyfractal added v7.7.0 and removed v7.6.0 labels Jan 15, 2020
@bpintea bpintea added v7.8.0 and removed v7.7.0 labels Mar 25, 2020
@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@andreidan andreidan added v7.11.0 and removed v7.10.0 labels Oct 7, 2020
@soarescaique
Copy link

Can I work on this? Would be a great issue.

@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@stu-elastic
Copy link
Contributor Author

The hard part is naming :-)

@stu-elastic stu-elastic removed the needs:triage Requires assignment of a team area label label Dec 9, 2020
@MarkRibeiro MarkRibeiro mentioned this issue Jun 21, 2021
Open
@joegallo joegallo added v7.16.0 and removed v7.15.0 labels Sep 22, 2021
@danhermann danhermann added v8.1.0 and removed v7.16.0 labels Oct 27, 2021
@arteam arteam removed the v8.0.0 label Jan 12, 2022
@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
@mark-vieira mark-vieira added v8.5.0 and removed v8.4.0 labels Jul 27, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@arpadkiraly arpadkiraly removed their assignment Mar 11, 2024
@rjernst
Copy link
Member

rjernst commented Apr 3, 2025

This hasn't been much of a problem after many years, so closing.

@rjernst rjernst closed this as completed Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests