Skip to content

Extend Yml dsl framework to skip per JDK version #51248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pgomulka opened this issue Jan 21, 2020 · 4 comments
Closed

Extend Yml dsl framework to skip per JDK version #51248

pgomulka opened this issue Jan 21, 2020 · 4 comments
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@pgomulka
Copy link
Contributor

pgomulka commented Jan 21, 2020

often times we depend on a feature available in certain JDK version. Given we support versions since jdk8 in 7.x branch it would be useful to write tests that depend on features available in newer versions.
Example would be loading SPI from classpath is a feature available since JDK9 (used for IsoCalendarProvider) #50916

@pgomulka pgomulka added the :Delivery/Build Build or test infrastructure label Jan 21, 2020
@pgomulka pgomulka self-assigned this Jan 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
@mark-vieira
Copy link
Contributor

Given we've bumped master to Java 17 I'm not sure this is really an issue. We are no longer using multi-release jars so we don't have any Java runtime specific functionality that I'm aware of.

@pgomulka
Copy link
Contributor Author

pgomulka commented May 9, 2022

I think this would be useful for bwc testing or 7.x branch testing. This is where jdk8 still can be used in testing as per https://www.elastic.co/support/matrix#matrix_jvm
Imagine a test (not sure we have one like this at the moment) where a search is using a week based year date format. This format depends on a definition of first day of the week and a rule how to calculate first week of a year. We define these in

public class IsoCalendarDataProvider extends CalendarDataProvider {
and use a feature available since jdk9 to allow loading extension classes from classpath https://bugs.openjdk.java.net/browse/JDK-8062588

I would consider this a super minor issue though

@rjernst
Copy link
Member

rjernst commented Aug 7, 2024

This issue has been open a while and hasn't gained any traction. Given that I'm going to close, and we can reopen if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

No branches or pull requests

4 participants