Skip to content

Add circuit breaker to QueryStringQueryParser #51403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
romseygeek opened this issue Jan 24, 2020 · 4 comments
Open

Add circuit breaker to QueryStringQueryParser #51403

romseygeek opened this issue Jan 24, 2020 · 4 comments
Labels
>enhancement :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch

Comments

@romseygeek
Copy link
Contributor

The QueryStringQueryParser can produce extremely large queries that don't get caught quickly enough by our boolean query limit checks - for example, a string that contains large numbers of spaces and wildcards can produce lots of very heavy Wildcard or Prefix queries over multiple fields. We should add some query-construction time checks to ensure that these sort of heavy queries don't overwhelm a node before they've even had time to run.
@romseygeek romseygeek added :Search/Search Search-related issues that do not fall into other categories :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload labels Jan 24, 2020
@romseygeek romseygeek self-assigned this Jan 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Circuit Breakers)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@jimczi jimczi mentioned this issue Feb 6, 2020
Merged
@rjernst rjernst added Team:Core/Infra Meta label for core/infra team Team:Search Meta label for search team labels May 4, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@romseygeek romseygeek removed :Core/Infra/Circuit Breakers Track estimates of memory consumption to prevent overload Team:Core/Infra Meta label for core/infra team needs:triage Requires assignment of a team area label labels Dec 15, 2020
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@benwtrent benwtrent added :Search Relevance/Search Catch all for Search Relevance and removed :Search/Search Search-related issues that do not fall into other categories labels Jul 12, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rjernst @javanna @romseygeek @benwtrent @elasticmachine @elasticsearchmachine