Log failure when cleaning shard follow task #51971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clenaing a shard follow task after an index has been deleted, an exception can occur submitting the complete persistent task action. However, this exception message is not logged. This commit addresses this by including the exception that led to the failure in the log message.
jasontedor
added
>non-issue
:Distributed Indexing/CCR
|
Pinging @elastic/es-distributed (:Distributed/CCR) |
jasontedor
commented
Feb 6, 2020
| @@ -63,9 +64,9 @@ public void clusterChanged(final ClusterChangedEvent event) { | |||
| // the index exists, do not clean this persistent task | |||
| continue; | |||
| } | |||
| IndexNotFoundException e = new IndexNotFoundException(followerIndex); | |||
| IndexNotFoundException infe = new IndexNotFoundException(followerIndex); | |||
There was a problem hiding this comment.
This name change is to avoid confusion with the name of the Exception instance in the onFailure callback.
jasontedor
added a commit
that referenced
this pull request
Feb 6, 2020
When clenaing a shard follow task after an index has been deleted, an exception can occur submitting the complete persistent task action. However, this exception message is not logged. This commit addresses this by including the exception that led to the failure in the log message.
jasontedor
added a commit
that referenced
this pull request
Feb 6, 2020
When clenaing a shard follow task after an index has been deleted, an exception can occur submitting the complete persistent task action. However, this exception message is not logged. This commit addresses this by including the exception that led to the failure in the log message.
jasontedor
added a commit
that referenced
this pull request
Feb 6, 2020
When clenaing a shard follow task after an index has been deleted, an exception can occur submitting the complete persistent task action. However, this exception message is not logged. This commit addresses this by including the exception that led to the failure in the log message.
jasontedor
deleted the
shard-follow-task-cleaner-on-failure-log-exception
branch
|
Thanks Jason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clenaing a shard follow task after an index has been deleted, an exception can occur submitting the complete persistent task action. However, this exception message is not logged. This commit addresses this by including the exception that led to the failure in the log message.
Relates #44702