Skip to content

Disable rate limiting for ingest scripts #58008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stu-elastic opened this issue Jun 11, 2020 · 6 comments
Closed

Disable rate limiting for ingest scripts #58008

stu-elastic opened this issue Jun 11, 2020 · 6 comments
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Core/Infra Meta label for core/infra team Team:Data Management Meta label for data/management team

Comments

@stu-elastic
Copy link
Contributor

stu-elastic commented Jun 11, 2020 •
edited
Loading

With recent changes to ingest pipelines, scripts are eagerly compiled at pipeline registration.

Since stored scripts are rare for ingest pipelines, we can avoid user pain by skipping compilation rate limiting.

TODO: validate "Since stored scripts are rare for ingest pipelines"

We should also deprecate stored scripts for ingest pipelines.
@stu-elastic stu-elastic added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Jun 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 11, 2020
@jakelandis
Copy link
Contributor

jakelandis commented Jun 11, 2020 •
edited
Loading

TODO: validate "Since stored scripts are rare for ingest pipelines"

@ph - do you know if any of the Elastic ingest management or beats use stored scripts for their pipelines

@jakelandis
Copy link
Contributor

@stu-elastic - this may duplicated with #49763 where we discussed this and tentativly agreed that would be good idea, but was blocked #50152. Is it possible to disable rate limiting for ingest scripts without #50152 ?

@stu-elastic
Copy link
Contributor Author

Hey @jakelandis #50152 is in master and got delayed on backport, which I'm back to now. I'll take this one once that backport is done.

@stu-elastic
Copy link
Contributor Author

Closed by #59267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Core/Infra Meta label for core/infra team Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakelandis @elasticmachine @stu-elastic