Skip to content

Fast grok access in painless #60766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stu-elastic opened this issue Aug 5, 2020 · 3 comments
Closed

Fast grok access in painless #60766

stu-elastic opened this issue Aug 5, 2020 · 3 comments
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team

Comments

@stu-elastic
Copy link
Contributor

stu-elastic commented Aug 5, 2020

We need to precompile the pattern for grok access to be fast.

We can use a compiler phase for this. That precludes passing in patterns as params and, for the initial release, precludes custom patterns.

Extensions:

  • Custom patterns can be added after we think about the API.

depends on: #51955, #49873

ref: #60659

@stu-elastic stu-elastic added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache labels Aug 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Aug 5, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@stu-elastic
Copy link
Contributor Author

Not on the radar, will reopen if necessary.

@stu-elastic stu-elastic removed the needs:triage Requires assignment of a team area label label Jan 12, 2021
@nik9000 nik9000 reopened this Jan 21, 2021
@javanna
Copy link
Member

javanna commented May 27, 2021

I opened #73468 as a follow-up to allow custom pattern definitions, but grok has already been made available in painless as a function. Closing then.

@javanna javanna closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

No branches or pull requests

5 participants