Skip to content

Point in Time should handle security on aliases #61547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimczi opened this issue Aug 25, 2020 · 3 comments · Fixed by #69572
Closed

Point in Time should handle security on aliases #61547

jimczi opened this issue Aug 25, 2020 · 3 comments · Fixed by #69572
Assignees
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Docs Meta label for docs team Team:Search Meta label for search team Team:Security Meta label for security team

Comments

@jimczi
Copy link
Contributor

jimczi commented Aug 25, 2020

In #61062 we introduced a new feature called PIT that allows to reuse the same context on multiple queries.
We've decided to merge the feature in advance but there is still one thing that we need to fix/decide. The PIT relies on the concrete index names that were resolved when the PIT was created. That allows to keep the scope of a PIT to only indices that existed when the PIT was created but that makes the security on aliases more challenging. Today we allow aliases to have different permissions than their targeted indices. Even though this feature is deprecated in security at the moment, it is unclear if we'll remove it in the future. So for PIT, we've decided to disallow the creation if an alias with a different permission is used in the creation request. This issue is a placeholder to ensure that we implement this protection before 7.10.
That should be temporary until the @elastic/es-security team revises the plan to un-deprecate or to remove this problematic use case definitely. If the decision is to un-deprecate we'll of course need to support the use case in PIT but that decision can wait after 7.10 is released.

@jimczi jimczi added >bug blocker :Search/Search Search-related issues that do not fall into other categories :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC v7.10.0 labels Aug 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added Team:Security Meta label for security team Team:Search Meta label for search team labels Aug 25, 2020
@jimczi jimczi added >docs General docs changes and removed >bug blocker v7.10.0 labels Oct 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Oct 6, 2020
@jimczi
Copy link
Contributor Author

jimczi commented Oct 6, 2020

We discussed offline with @albertzaharovits and decided to document the fact that PITs will handle security at the concrete index level. If an alias is used to create a PIT, it is replaced by the concrete indices that it targets at the time when the PIT is created. These concrete indices are the one that we expose when the PIT is used in a search request so security will always resolve from the concrete list. This is consistent with the overall plan regarding alias security since we'll disallow aliases with different permissions in 8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Docs Meta label for docs team Team:Search Meta label for search team Team:Security Meta label for security team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants