-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Task Cancellation Enhancements #67505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging @elastic/es-distributed (Team:Distributed) |
I can see some value in the first idea although really IMO it's a bug not to check for cancellation frequently enough for this to matter. For (2) I much prefer the more recent approach that lets a client cancel its own tasks by disconnecting. Permitting a user to cancel another user's tasks, or even some internal system tasks, is problematic, and letting them cancel tasks in bulk is just scaling up the problem. |
See #51628 for info on the planned future direction of the tasks APIs, and note in particular that we have decided to implement dedicated cancellation APIs on a case-by-case basis rather than rely on the general-purpose task cancellation API. |
A user raised with me that this first suggestion (plus #17094) would be particularly useful with force-merging. Today there's no way to cancel a force-merge on a shard but we can at least indicate in the UI that it's been cancelled while you're waiting and therefore that we won't start any further per-shard work. |
Closing this in favour of #72907. |
Problem
CancellableTask#isCancelled
, the list task API continues to show the task on the task manager without an indication of whether the task/child task was cancelled, though it might eventually fail/abort.The text was updated successfully, but these errors were encountered: