Skip to content

Consolidate the authentication result caches #70900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ywangd opened this issue Mar 26, 2021 · 1 comment
Open

Consolidate the authentication result caches #70900

ywangd opened this issue Mar 26, 2021 · 1 comment
Assignees
Labels
>enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team

Comments

@ywangd
Copy link
Member

ywangd commented Mar 26, 2021

As discussed over a comment of #70543, there is an opportunity to consolidate existing caches used for authentication results. These are the one used for CachingUsernamePasswordRealm, ApiKeyService and CachingServiceAccountsTokenStore. Their implementations are largely identical. The different authentication result can be generialised. We should be able to have a common implementation for all of them. We could also consider using composition over inheritance when we are at it.

@ywangd ywangd added >enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) labels Mar 26, 2021
@ywangd ywangd self-assigned this Mar 26, 2021
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Mar 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team
Projects
None yet
Development

No branches or pull requests

2 participants