Skip to content

Remove usage of SortedSetDocValues#NO_MORE_ORDS #88004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jpountz opened this issue Jun 24, 2022 · 6 comments
Closed

Remove usage of SortedSetDocValues#NO_MORE_ORDS #88004

jpountz opened this issue Jun 24, 2022 · 6 comments
Labels
:Analytics/Aggregations Aggregations >enhancement :Search Foundations/Search Catch all for Search Foundations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@jpountz
Copy link
Contributor

jpountz commented Jun 24, 2022

Description

Lucene's SortedSetDocValues got a new SortedSetDocValues#docValueCount API that allows getting the number of values of a document without iterating through all values. We should change the iteration logic to use this count and consume count ords instead of iterating all ords until NO_MORE_ORDS is returned.

This should speed up some queries, e.g. value_count aggregations through the refactoring of FieldData#toString(SortedSetDocValues) to not iterate through all values to figure out the number of values.
@jpountz jpountz added >enhancement :Search/Search Search-related issues that do not fall into other categories labels Jun 24, 2022
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jun 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@wchaparro
Copy link
Member

Added to: #65019

@wchaparro wchaparro mentioned this issue Jul 28, 2023
Open
@javanna javanna added :Search Foundations/Search Catch all for Search Foundations and removed :Search/Search Search-related issues that do not fall into other categories labels Jul 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine removed the Team:Search Meta label for search team label Jul 17, 2024
@javanna
Copy link
Member

javanna commented Feb 13, 2025

NO_MORE_ORDS has been deprecated and removed with Lucene 10. We have addressed all the usages and replaced them with docValueCount as part of the lucene 10 upgrade, see #114741.

@javanna javanna closed this as completed Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >enhancement :Search Foundations/Search Catch all for Search Foundations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jpountz @javanna @jtibshirani @wchaparro @elasticmachine @elasticsearchmachine