diff --git a/modules/lang-painless/spi/src/main/java/org/elasticsearch/painless/spi/WhitelistLoader.java b/modules/lang-painless/spi/src/main/java/org/elasticsearch/painless/spi/WhitelistLoader.java
index c59023b862280..a4a0076626a9c 100644
--- a/modules/lang-painless/spi/src/main/java/org/elasticsearch/painless/spi/WhitelistLoader.java
+++ b/modules/lang-painless/spi/src/main/java/org/elasticsearch/painless/spi/WhitelistLoader.java
@@ -53,7 +53,7 @@ public final class WhitelistLoader {
* a Painless type name with the exception that any dollar symbols used as part of inner classes will
* be replaced with dot symbols.
*
short Java type name - The text after the final dot symbol of any specified Java class. A
- * short type Java name may be excluded by using the 'only_fqn' token during Painless class parsing
+ * short type Java name may be excluded by using the 'no_import' token during Painless class parsing
* as described later.
*
*
@@ -65,7 +65,7 @@ public final class WhitelistLoader {
* Primitive types may be specified starting with 'class' and followed by the Java type name,
* an opening bracket, a newline, a closing bracket, and a final newline.
* Complex types may be specified starting with 'class' and followed the fully-qualified Java
- * class name, optionally followed by an 'only_fqn' token, an opening bracket, a newline,
+ * class name, optionally followed by an 'no_import' token, an opening bracket, a newline,
* constructor/method/field specifications, a closing bracket, and a final newline. Within a complex
* type the following may be parsed:
*
@@ -109,7 +109,7 @@ public final class WhitelistLoader {
*
* # complex types
*
- * class my.package.Example only_fqn {
+ * class my.package.Example no_import {
* # constructors
* ()
* (int)
@@ -145,7 +145,7 @@ public static Whitelist loadFromResourceFiles(Class> resource, String... filep
String whitelistClassOrigin = null;
String javaClassName = null;
- boolean onlyFQNJavaClassName = false;
+ boolean noImport = false;
List whitelistConstructors = null;
List whitelistMethods = null;
List whitelistFields = null;
@@ -160,7 +160,7 @@ public static Whitelist loadFromResourceFiles(Class> resource, String... filep
}
// Handle a new class by resetting all the variables necessary to construct a new WhitelistClass for the whitelist.
- // Expects the following format: 'class' ID 'only_fqn'? '{' '\n'
+ // Expects the following format: 'class' ID 'no_import'? '{' '\n'
if (line.startsWith("class ")) {
// Ensure the final token of the line is '{'.
if (line.endsWith("{") == false) {
@@ -172,8 +172,8 @@ public static Whitelist loadFromResourceFiles(Class> resource, String... filep
String[] tokens = line.substring(5, line.length() - 1).trim().split("\\s+");
// Ensure the correct number of tokens.
- if (tokens.length == 2 && "only_fqn".equals(tokens[1])) {
- onlyFQNJavaClassName = true;
+ if (tokens.length == 2 && "no_import".equals(tokens[1])) {
+ noImport = true;
} else if (tokens.length != 1) {
throw new IllegalArgumentException("invalid class definition: failed to parse class name [" + line + "]");
}
@@ -194,13 +194,13 @@ public static Whitelist loadFromResourceFiles(Class> resource, String... filep
throw new IllegalArgumentException("invalid class definition: extraneous closing bracket");
}
- whitelistClasses.add(new WhitelistClass(whitelistClassOrigin, javaClassName, onlyFQNJavaClassName,
+ whitelistClasses.add(new WhitelistClass(whitelistClassOrigin, javaClassName, noImport,
whitelistConstructors, whitelistMethods, whitelistFields));
// Set all the variables to null to ensure a new class definition is found before other parsable values.
whitelistClassOrigin = null;
javaClassName = null;
- onlyFQNJavaClassName = false;
+ noImport = false;
whitelistConstructors = null;
whitelistMethods = null;
whitelistFields = null;
diff --git a/modules/lang-painless/src/main/java/org/elasticsearch/painless/lookup/PainlessLookupBuilder.java b/modules/lang-painless/src/main/java/org/elasticsearch/painless/lookup/PainlessLookupBuilder.java
index 0346867d35aa3..e644453a4c1ba 100644
--- a/modules/lang-painless/src/main/java/org/elasticsearch/painless/lookup/PainlessLookupBuilder.java
+++ b/modules/lang-painless/src/main/java/org/elasticsearch/painless/lookup/PainlessLookupBuilder.java
@@ -293,7 +293,7 @@ public void addPainlessClass(Class> clazz, boolean importClassName) {
if (canonicalClassName.equals(importedCanonicalClassName)) {
if (importClassName == true) {
- throw new IllegalArgumentException("must use only_fqn parameter on class [" + canonicalClassName + "] with no package");
+ throw new IllegalArgumentException("must use no_import parameter on class [" + canonicalClassName + "] with no package");
}
} else {
Class> importedPainlessClass = canonicalClassNamesToClasses.get(importedCanonicalClassName);
@@ -301,7 +301,8 @@ public void addPainlessClass(Class> clazz, boolean importClassName) {
if (importedPainlessClass == null) {
if (importClassName) {
if (existingPainlessClassBuilder != null) {
- throw new IllegalArgumentException("inconsistent only_fqn parameters found for class [" + canonicalClassName + "]");
+ throw new IllegalArgumentException(
+ "inconsistent no_import parameters found for class [" + canonicalClassName + "]");
}
canonicalClassNamesToClasses.put(importedCanonicalClassName, clazz);
@@ -310,7 +311,7 @@ public void addPainlessClass(Class> clazz, boolean importClassName) {
throw new IllegalArgumentException("imported class [" + importedCanonicalClassName + "] cannot represent multiple " +
"classes [" + canonicalClassName + "] and [" + typeToCanonicalTypeName(importedPainlessClass) + "]");
} else if (importClassName == false) {
- throw new IllegalArgumentException("inconsistent only_fqn parameters found for class [" + canonicalClassName + "]");
+ throw new IllegalArgumentException("inconsistent no_import parameters found for class [" + canonicalClassName + "]");
}
}
}
diff --git a/modules/lang-painless/src/main/resources/org/elasticsearch/painless/spi/org.elasticsearch.txt b/modules/lang-painless/src/main/resources/org/elasticsearch/painless/spi/org.elasticsearch.txt
index f424f6acf25aa..a3ff479533bd2 100644
--- a/modules/lang-painless/src/main/resources/org/elasticsearch/painless/spi/org.elasticsearch.txt
+++ b/modules/lang-painless/src/main/resources/org/elasticsearch/painless/spi/org.elasticsearch.txt
@@ -24,31 +24,31 @@
#### Primitive types
-class void only_fqn {
+class void no_import {
}
-class boolean only_fqn {
+class boolean no_import {
}
-class byte only_fqn {
+class byte no_import {
}
-class short only_fqn {
+class short no_import {
}
-class char only_fqn {
+class char no_import {
}
-class int only_fqn {
+class int no_import {
}
-class long only_fqn {
+class long no_import {
}
-class float only_fqn {
+class float no_import {
}
-class double only_fqn {
+class double no_import {
}
#### Painless debugging API
@@ -134,7 +134,7 @@ class org.elasticsearch.index.mapper.IpFieldMapper$IpFieldType$IpScriptDocValues
# for testing.
# currently FeatureTest exposes overloaded constructor, field load store, and overloaded static methods
-class org.elasticsearch.painless.FeatureTest only_fqn {
+class org.elasticsearch.painless.FeatureTest no_import {
int z
()
(int,int)