From da4106b6b87b00ccae5a36685c37f6cdf9a8afa7 Mon Sep 17 00:00:00 2001
From: Armin Braun <me@obrown.io>
Date: Wed, 8 Jan 2020 12:24:15 +0100
Subject: [PATCH] Fix and Reenable SnapshotTool Minio Tests

This solves half of the problem in #46813 by moving the S3
tests to using the shared minio fixture so we at least have
some non-3rd-party, constantly running coverage on these tests.
---
 plugins/repository-s3/build.gradle            |  2 +-
 .../fixtures/minio-fixture/docker-compose.yml | 12 ++++++
 x-pack/snapshot-tool/qa/s3/build.gradle       | 39 ++++---------------
 x-pack/snapshot-tool/qa/s3/docker-compose.yml |  9 -----
 4 files changed, 21 insertions(+), 41 deletions(-)
 delete mode 100644 x-pack/snapshot-tool/qa/s3/docker-compose.yml

diff --git a/plugins/repository-s3/build.gradle b/plugins/repository-s3/build.gradle
index e26fa43188b44..34660f6b2b54b 100644
--- a/plugins/repository-s3/build.gradle
+++ b/plugins/repository-s3/build.gradle
@@ -141,7 +141,7 @@ task thirdPartyTest(type: Test) {
 }
 
 if (useFixture) {
-  testFixtures.useFixture(':test:fixtures:minio-fixture')
+  testFixtures.useFixture(':test:fixtures:minio-fixture', 'minio-fixture')
 
   def minioAddress = {
     int minioPort = project(':test:fixtures:minio-fixture').postProcessFixture.ext."test.fixtures.minio-fixture.tcp.9000"
diff --git a/test/fixtures/minio-fixture/docker-compose.yml b/test/fixtures/minio-fixture/docker-compose.yml
index 5cd14ceec8e29..e4df64ad75fcb 100644
--- a/test/fixtures/minio-fixture/docker-compose.yml
+++ b/test/fixtures/minio-fixture/docker-compose.yml
@@ -11,3 +11,15 @@ services:
     ports:
       - "9000"
     command: ["server", "/minio/data"]
+
+  minio-fixture-for-snapshot-tool:
+      build:
+        context: .
+        args:
+          bucket: "bucket"
+          accessKey: "sn_tool_access_key"
+          secretKey: "sn_tool_secret_key"
+        dockerfile: Dockerfile
+      ports:
+        - "9000"
+      command: ["server", "/minio/data"]
diff --git a/x-pack/snapshot-tool/qa/s3/build.gradle b/x-pack/snapshot-tool/qa/s3/build.gradle
index 7d4e04e13c6cc..9f97279b109cb 100644
--- a/x-pack/snapshot-tool/qa/s3/build.gradle
+++ b/x-pack/snapshot-tool/qa/s3/build.gradle
@@ -4,6 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 apply plugin: 'elasticsearch.build'
+apply plugin: 'elasticsearch.test.fixtures'
 
 dependencies {
   compile project(":plugins:repository-s3")
@@ -26,9 +27,9 @@ String s3PermanentBucket = System.getenv("amazon_s3_bucket")
 String s3PermanentBasePath = System.getenv("amazon_s3_base_path")
 
 if (!s3PermanentAccessKey && !s3PermanentSecretKey && !s3PermanentBucket && !s3PermanentBasePath) {
-  s3PermanentAccessKey = 's3_integration_test_permanent_access_key'
-  s3PermanentSecretKey = 's3_integration_test_permanent_secret_key'
-  s3PermanentBucket = 'permanent-bucket-test'
+  s3PermanentAccessKey = 'sn_tool_access_key'
+  s3PermanentSecretKey = 'sn_tool_secret_key'
+  s3PermanentBucket = 'bucket'
   s3PermanentBasePath = 'integration_test'
 
   useS3Fixture = true
@@ -48,41 +49,17 @@ task thirdPartyTest(type: Test) {
 }
 
 if (useS3Fixture) {
-  thirdPartyTest.enabled = false;
   testingConventions.enabled = false;
-  /*
-
-  See: https://github.com/elastic/elasticsearch/issues/46813 Fails with --parallel
-
-  apply plugin: 'elasticsearch.test.fixtures'
-
-  testFixtures.useFixture()
-
-  task writeDockerFile {
-    File minioDockerfile = new File("${project.buildDir}/minio-docker/Dockerfile")
-    outputs.file(minioDockerfile)
-    doLast {
-      minioDockerfile.parentFile.mkdirs()
-      minioDockerfile.text =
-        "FROM minio/minio:RELEASE.2019-01-23T23-18-58Z\n" +
-          "RUN mkdir -p /minio/data/${s3PermanentBucket}\n" +
-          "ENV MINIO_ACCESS_KEY ${s3PermanentAccessKey}\n" +
-          "ENV MINIO_SECRET_KEY ${s3PermanentSecretKey}"
-    }
-  }
-
-  preProcessFixture {
-    dependsOn(writeDockerFile)
-  }
+  testFixtures.useFixture(':test:fixtures:minio-fixture', "minio-fixture-for-snapshot-tool")
 
   def minioAddress = {
-    int minioPort = postProcessFixture.ext."test.fixtures.minio-fixture.tcp.9000"
+    int minioPort = project(':test:fixtures:minio-fixture').postProcessFixture.ext."test.fixtures.minio-fixture-for-snapshot-tool.tcp.9000"
     assert minioPort > 0
     'http://127.0.0.1:' + minioPort
   }
 
   thirdPartyTest {
-    dependsOn tasks.postProcessFixture
+    dependsOn project(':test:fixtures:minio-fixture').postProcessFixture
     nonInputProperties.systemProperty 'test.s3.endpoint', "${-> minioAddress.call()}"
   }
 
@@ -91,7 +68,7 @@ if (useS3Fixture) {
       throw new IllegalStateException("Tried to run third party tests but not all of the necessary environment variables 'amazon_s3_access_key', " +
         "'amazon_s3_secret_key', 'amazon_s3_bucket', and 'amazon_s3_base_path' are set.");
     }
-  }*/
+  }
 }
 
 check.dependsOn(thirdPartyTest)
diff --git a/x-pack/snapshot-tool/qa/s3/docker-compose.yml b/x-pack/snapshot-tool/qa/s3/docker-compose.yml
deleted file mode 100644
index e44750550e271..0000000000000
--- a/x-pack/snapshot-tool/qa/s3/docker-compose.yml
+++ /dev/null
@@ -1,9 +0,0 @@
-version: '3'
-services:
-  minio-fixture:
-    build:
-      context: ./build/minio-docker
-      dockerfile: Dockerfile
-    ports:
-      - "9000"
-    command: ["server", "/minio/data"]
\ No newline at end of file