From 9bf53fd25c33b9d6a226559e22e2286c548877d6 Mon Sep 17 00:00:00 2001 From: pgomulka Date: Wed, 20 Oct 2021 11:06:36 +0200 Subject: [PATCH 1/2] [DOCS] Document deprecation of storing nanosecond resolution on date field relates #78921 --- .../reference/migration/migrate_7_16.asciidoc | 20 ++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/docs/reference/migration/migrate_7_16.asciidoc b/docs/reference/migration/migrate_7_16.asciidoc index 1e4d6dbcffe82..9f0e0ac9793c3 100644 --- a/docs/reference/migration/migrate_7_16.asciidoc +++ b/docs/reference/migration/migrate_7_16.asciidoc @@ -88,7 +88,7 @@ logging>>. ==== *Details* + In SAML, Identity Providers (IdPs) can either be explicitly configured to -release a `NameID` with a specific format, or configured to attempt to conform +release a `NameID` with a specific format, or configured to attempt to conform with the requirements of a Service Provider (SP). The SP declares its requirements in the `NameIDPolicy` element of a SAML Authentication Request. In {es}, the `nameid_format` SAML realm setting controls the `NameIDPolicy` @@ -103,9 +103,9 @@ IdP. If you want to retain the previous behavior, set `nameid_format` to *Impact* + If you currently don't configure `nameid_format` explicitly, it's possible -that your IdP will reject authentication requests from {es} because the requests +that your IdP will reject authentication requests from {es} because the requests do not specify a `NameID` format (and your IdP is configured to expect one). -This mismatch can result in a broken SAML configuration. If you're unsure whether +This mismatch can result in a broken SAML configuration. If you're unsure whether your IdP is explicitly configured to use a certain `NameID` format and you want to retain current behavior , try setting `nameid_format` to `urn:oasis:names:tc:SAML:2.0:nameid-format:transient` explicitly. ==== @@ -347,4 +347,18 @@ cache do not expire. To override the defaults, configure the `script.cache.max_size`, `script.max_compilations_rate`, and `script.cache.expire` settings. ==== + +.Attempting to store nanosecond resolution in a date field is deprecated. +[%collapsible] +==== +*Details* + +Attempting to store a nanosecond resolution in a date field is deprecated. +This behaviour was allowed so far, but was always resulting in resolution loss. +A {ref}/date.html[`date`] field can only store up to millisecond resolutions. +*Impact* + +If you attempt to store a nanosecond resolution in a `date` type field, {es} will +emit a deprecation warning. To avoid deprecation warnings, use a +{ref}/date_nanos.html[`date_nanos`] field instead. +==== + // end::notable-breaking-changes[] From f9b3c05c2bc9b5412bd2ce08e7c09b4ee012a3c0 Mon Sep 17 00:00:00 2001 From: Przemyslaw Gomulka Date: Wed, 20 Oct 2021 15:03:59 +0200 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com> --- docs/reference/migration/migrate_7_16.asciidoc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/reference/migration/migrate_7_16.asciidoc b/docs/reference/migration/migrate_7_16.asciidoc index 9f0e0ac9793c3..d24a5e030538c 100644 --- a/docs/reference/migration/migrate_7_16.asciidoc +++ b/docs/reference/migration/migrate_7_16.asciidoc @@ -348,13 +348,14 @@ To override the defaults, configure the `script.cache.max_size`, `script.max_compilations_rate`, and `script.cache.expire` settings. ==== -.Attempting to store nanosecond resolution in a date field is deprecated. +.Attempting to store nanosecond resolution in a `date` field is deprecated. [%collapsible] ==== *Details* + -Attempting to store a nanosecond resolution in a date field is deprecated. -This behaviour was allowed so far, but was always resulting in resolution loss. -A {ref}/date.html[`date`] field can only store up to millisecond resolutions. +Attempting to store a nanosecond resolution in a {ref}/date.html[`date`] field is deprecated. +While previously allowed, these attempts always resulted in resolution loss. +A `date` field can only store up to millisecond resolutions. + *Impact* + If you attempt to store a nanosecond resolution in a `date` type field, {es} will emit a deprecation warning. To avoid deprecation warnings, use a