Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

Commit 6f396cb

Browse files
committed
No longer validate ES_HOME in ValidateArgumentsTask
We validate the presense of `ES_HOME` but no prior installation to prevent folks from upgrading from a zip distribution. We only did this validation on the first custom action as later on we ourselves set ES_HOME during the installation. Setting the es var is part of the wxs declaration though and does not happen as part of a custom action. When we built and tested this against 6.3.2 our automated testing was all green. Now using the 6.4.0 snapshot build a vanilla install fails. This PR removes the check inside the custom action. Still need to investigate what causes this difference
1 parent 61c9332 commit 6f396cb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/InstallerHosts/Elastic.InstallerHosts/Elasticsearch/Tasks/Immediate/ValidateArgumentsTask.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace Elastic.InstallerHosts.Elasticsearch.Tasks.Immediate
77
{
88
public class ValidateArgumentsTask : ElasticsearchInstallationTaskBase
99
{
10-
public ValidateArgumentsTask(string[] args, ISession session) : base(args, session, installationInProgress: false) { }
10+
public ValidateArgumentsTask(string[] args, ISession session) : base(args, session) { }
1111

1212
protected override bool ExecuteTask()
1313
{

0 commit comments

Comments
 (0)