Exposed disable automatic proxy detection

Author: Mpdreamz

src/Elasticsearch.Net/Connection/Configuration/ConnectionConfiguration.cs

@@ -88,8 +88,8 @@ public class ConnectionConfiguration<T> : IConnectionConfigurationValues, IHideO
 #endif
 		bool IConnectionConfigurationValues.MetricsEnabled { get{ return _enableMetrics; } }
 
-        private bool _automaticProxyDetection = true;
-        bool IConnectionConfigurationValues.AutomaticProxyDetection { get { return _automaticProxyDetection; } }
+        private bool _disableAutomaticProxyDetection = true;
+        bool IConnectionConfigurationValues.DisableAutomaticProxyDetection { get { return _disableAutomaticProxyDetection; } }
 
 		private int _maximumAsyncConnections;
 		int IConnectionConfigurationValues.MaximumAsyncConnections { get{ return _maximumAsyncConnections; } }
@@ -181,6 +181,11 @@ public T EnableTrace(bool enabled = true)
 			return (T) this;
 		}
 
+		public T DisableAutomaticProxyDetection(bool disable = true)
+		{
+			this._disableAutomaticProxyDetection = disable;
+			return (T)this;
+		}
 
 		/// <summary>
 		/// By enabling metrics more metadata is returned per API call about requests (ping, sniff, failover) and general stats

src/Elasticsearch.Net/Connection/Configuration/IConnectionConfigurationValues.cs

@@ -26,7 +26,7 @@ public interface IConnectionConfigurationValues
 		bool MetricsEnabled { get; }
 		bool UsesPrettyResponses { get; }
 		bool KeepRawResponse { get; }
-        bool AutomaticProxyDetection { get; }
+        bool DisableAutomaticProxyDetection { get; }
 
 		/// <summary>
 		/// Instead of following a c/go like error checking on response.IsValid always throw an ElasticsearchServerException

src/Elasticsearch.Net/Connection/HttpConnection.cs

@@ -157,7 +157,8 @@ private void SetProxyIfNeeded(HttpWebRequest myReq)
 				proxy.Credentials = credentials;
 				myReq.Proxy = proxy;
 			}
-            if(!this.ConnectionSettings.AutomaticProxyDetection)
+
+            if(this.ConnectionSettings.DisableAutomaticProxyDetection)
             {
                 myReq.Proxy = null;
             }

src/Elasticsearch.Net/Connection/Transport.cs

@@ -82,7 +82,7 @@ private bool Ping(ITransportRequestState requestState)
 					rq.Finish(response.Success, response.HttpStatusCode);
 				}
 				if (!response.HttpStatusCode.HasValue || response.HttpStatusCode.Value == -1)
-					throw new Exception("ping returned no status code");
+					throw new Exception("ping returned no status code", response.OriginalException);
 				if (response.Response == null)
 					return response.Success;
 

src/Tests/Nest.Tests.Integration/Exceptions/ElasticsearchExceptionTests.cs

@@ -121,7 +121,6 @@ public void ConnectionPool_SingleNode_PingExceptionThrowsMaxRetry()
 			{
 				var result = client.Search<ElasticsearchProject>(s => s.MatchAll());
 				result.IsValid.Should().BeFalse();
-				client.RootNodeInfo(r => r.RequestConfiguration(c => c.ConnectTimeout(2000)));
 			});
 			e.Should().NotBeNull();
 			Assert.Pass(e.ToString());
@@ -140,7 +139,9 @@ public void ConnectionPool_SingleNode_PingExceptionThrowsMaxRetry_Async()
 			);
 			var e = Assert.Throws<MaxRetryException>(async () =>
 			{
-				var result = await client.SearchAsync<ElasticsearchProject>(s => s.MatchAll());
+				var result = await client.SearchAsync<ElasticsearchProject>(s => s
+					.MatchAll()
+				);
 				result.IsValid.Should().BeFalse();
 			});
 			e.Should().NotBeNull();