Nest - undocmented breaking change - 0.0.0.12 to 1.0 beta 1 - BulkResponse.Items OK

[crunchie84]

You can no longer find out if any items have failed indexing from within the IBulkResponse

0.0.0.12 syntax:

var itemsWhichFailedToIndex = IBulkResponse.Items.Where(i => !i.OK)

Please advice how to fix this?

[danblair]

I ran into this also yesterday. I've added an additional check of seeing if an Error exists also.

results.Items.Where(x => x != null && !x.OK && !String.IsNullOrWhiteSpace(x.Error))

So far it seems to work. Also, it's important to note that the index was being updated in my case even though OK was returning false.

[Mpdreamz]

Looking for invalid items is now a lot easier:

var result = this._client.Bulk(b => b
    .Create<ElasticsearchProject>(i => i.Object(new ElasticsearchProject { Id = 123123 }))
    .Create<ElasticsearchProject>(i => i.Object(new ElasticsearchProject { Id = 123123 }))
);

result.IsValid.Should().BeFalse();
result.Errors.Should().BeTrue();
result.ItemsWithErrors.Should().NotBeEmpty().And.HaveCount(1);