Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assemblies CLS-compliant #623

Closed
ghost opened this issue Apr 24, 2014 · 2 comments
Closed

Make assemblies CLS-compliant #623

ghost opened this issue Apr 24, 2014 · 2 comments
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Apr 24, 2014

Please add [assembly: CLSCompliant(true)] to Nest and Elasticsearch.Net.

@ghost ghost changed the title Make asseblies CLS-compliant Make assemblies CLS-compliant Apr 24, 2014
@Mpdreamz
Copy link
Member

The reason I left it out was that I never personally needed it but have no reservations adding it in.

Is there a verifier that I can use that the client IS actually CLSCompliant ?

Also interested to hear your use case that needs it!

@Mpdreamz Mpdreamz added this to the NEST 1.0-beta2 milestone May 5, 2014
@Mpdreamz
Copy link
Member

Mpdreamz commented May 6, 2014

Elasticsearch.Net is now CLSCompliant (also fixed all the resulting warnings)

Nest CLSCompliancy blocks on the work being done in this branch https://github.com/elasticsearch/elasticsearch-net/tree/feature/exposable-query-dsl

That replaces all the internal properties prefixed with an underscore with explicit interface implementations.

NEST with CLSCompliant now has 34 compiler warnings

@gmarz gmarz closed this as completed Jul 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants