Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms Filter not applying Execution on all overloads #753

Closed
TruffleMuffin opened this issue Jul 3, 2014 · 0 comments
Closed

Terms Filter not applying Execution on all overloads #753

TruffleMuffin opened this issue Jul 3, 2014 · 0 comments

Comments

@TruffleMuffin
Copy link
Contributor

The Terms Filter is not applying Execution when specified on all of its overloads. This causes broken behaviour when attempting to do non default filtering with Terms.

For Example:

.Filter(f => f.Terms(t => t.Property, new string[] { "term1" }, TermsExecution.And))

Executes

{
  "filter": {
    "terms": { "property": [ "term1" ] }
  }
}

Instead of

{
  "filter": {
    "terms": { "property": [ "term1" ] },
    "execution": "and"
  }
}
@gmarz gmarz closed this as completed Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants