Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TermVector support #610

Merged
merged 6 commits into from
Apr 28, 2014
Merged

Added TermVector support #610

merged 6 commits into from
Apr 28, 2014

Conversation

gmarz
Copy link
Contributor

@gmarz gmarz commented Apr 23, 2014

See issue #519

@Mpdreamz
Copy link
Member

@gmarz you managed to get the code generation and such to work! 👍 👍 👍

@gmarz
Copy link
Contributor Author

gmarz commented Apr 24, 2014

@Mpdreamz Yup, it was pretty straightforward after you explained it. Now that we have a baseline for term vectors with this PR, MTermVectors (#507) should be relatively easy to implement. I'm going to try and get that in this week. I'd also like to include some tests as well.

@Mpdreamz
Copy link
Member

Im really really glad to hear that it wasn't too cumbersome, looking forward to #507.

@gmarz
Copy link
Contributor Author

gmarz commented Apr 26, 2014

@Mpdreamz Added support for multi termvectors (#507). Still need to add some tests. I also synced my fork, so these commits should be a little easier to merge.

@Mpdreamz
Copy link
Member

Hey @gmarz, leaving this open until one of us gets around to adding tests :)

Can't thank you enough for adding support for both of these ! 👍

@gmarz
Copy link
Contributor Author

gmarz commented Apr 27, 2014

@Mpdreamz Added a few base integration tests- should be a good start. Note that I had to add a term vector mapping in the integration setup. I felt the Content field of the ElasticsearchProject type was appropriate.

@Mpdreamz Mpdreamz merged commit b078e56 into elastic:master Apr 28, 2014
@Mpdreamz
Copy link
Member

Thanks @gmarz :)

Mpdreamz added a commit that referenced this pull request May 6, 2014
…ndexTypePath instead of DocumentTypePath, 'docs' body support seems to be missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants