Skip to content

Add support for 'no_match_size' to HighlightFieldDescriptor #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2014
Merged

Add support for 'no_match_size' to HighlightFieldDescriptor #678

merged 1 commit into from
Jun 2, 2014

Conversation

yreynhout
Copy link
Contributor

No description provided.

@yreynhout
Copy link
Contributor Author

From the docs: http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/search-request-highlighting.html#_highlighted_fragments

I have no idea how you're dealing with versioning vis-à-vis the elastic search api, so this may be inappropriate.

@Mpdreamz
Copy link
Member

I do not follow a versioning scheme that strictly pairs up with elasticsearch version numbers, since the assemblies are signed I try to be semver compliant.

Thanks for the PR @yreynhout mind signing the Elasticsearch CLA:

http://www.elasticsearch.org/contributor-agreement/

So that I may pull your bits in?

@yreynhout
Copy link
Contributor Author

I just signed it. Check with Legal that it happened. [Edit]I'm not inclined to put contracts I signed on a public GH repository. Hope you understand[/Edit]

@Mpdreamz Mpdreamz merged commit 1fad902 into elastic:master Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants