Skip to content

Commit dde9c2c

Browse files
hazzukt3chguyuhoregrenovate[bot]florianduros
authored
element-web v1.11.89 (#14)
* Update calls to addEventToTimeline and addLiveEvents for new signature Signed-off-by: Michael Telatynski <[email protected]> * Improve coverage Signed-off-by: Michael Telatynski <[email protected]> * Remove space-specific right panel store handling This is no longer needed as the right panel always corresponds to the currently viewed room/space only. Signed-off-by: Michael Telatynski <[email protected]> * Remove duplicates Signed-off-by: Michael Telatynski <[email protected]> * Fix release workflow permissions Signed-off-by: Michael Telatynski <[email protected]> * temporarily add a default branch to handle unknown shield codes (element-hq#28543) * Remove Twemoji SBIX font in favour of COLRv0 (element-hq#28549) * Remove Twemoji SBIX font in favour of COLRv0 as it is supported everywhere we need it Signed-off-by: Michael Telatynski <[email protected]> * Remove unused mock Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> * Show the correct shield status in tooltip for more conditions (element-hq#28476) * Add support for new shield codes in JS SDK * change string used for shield message * fix test * Update dependency @formatjs/intl-segmenter to v11.7.4 (element-hq#28558) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @vector-im/compound-design-tokens to v2.1.0 (element-hq#28563) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update docker (element-hq#28554) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update playwright to v1.49.0 (element-hq#28566) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency stylelint-scss to v6.10.0 (element-hq#28564) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @stylistic/eslint-plugin to v2.11.0 (element-hq#28562) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update definitelyTyped (element-hq#28557) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update linkify to v4.1.4 (element-hq#28560) * Update linkify to v4.1.4 * Fix types Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <[email protected]> * Update dependency @sentry/browser to v8.40.0 (element-hq#28561) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update guibranco/github-status-action-v2 digest to 66088c4 (element-hq#28555) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Replace `MatrixClient.isRoomEncrypted` by `MatrixClient.CryptoApi.isEncryptionEnabledInRoom` in RoomView (element-hq#28278) * Replace `MatrixClient.isRoomEncrypted` by `MatrixClient.CryptoApi.isEncryptionEnabledInRoom` in RoomView * Add `isRoomEncrypted` to room * Update e2eStatus and urlPreview when isRoomEncrypted is computed * Fix e2e test * Add tests when user verification change * Reduced abusive timeout in e2e test * Fix workflow permissions Signed-off-by: Michael Telatynski <[email protected]> * [create-pull-request] automated change (element-hq#28573) Co-authored-by: t3chguy <[email protected]> Co-authored-by: Michael Telatynski <[email protected]> * Update dependency caniuse-lite to v1.0.30001684 (element-hq#28559) * Update dependency caniuse-lite to v1.0.30001684 * Update tests Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <[email protected]> * Update typescript-eslint monorepo to v8.15.0 (element-hq#28567) * Update typescript-eslint monorepo to v8.15.0 * Add linter exception Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <[email protected]> * [create-pull-request] automated change (element-hq#28572) Co-authored-by: t3chguy <[email protected]> Co-authored-by: Michael Telatynski <[email protected]> * Add source-map-loader for easier debugging (element-hq#28580) of matrix-widget-api and other libs Signed-off-by: Michael Telatynski <[email protected]> * Apply release blocker checks to cut branches workflow (element-hq#28551) * Apply release blocker checks to cut branches workflow Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> * Add Modernizr warning when running in non-secure context (element-hq#28581) Signed-off-by: Michael Telatynski <[email protected]> * Check room encryption earlier (element-hq#28579) * Remove `Features.RustCrypto` (element-hq#28582) * Remove redundant MSC implementation for io.element.rendezvous (element-hq#28583) Signed-off-by: Michael Telatynski <[email protected]> * [create-pull-request] automated change (element-hq#28586) Co-authored-by: t3chguy <[email protected]> * Fix format bar position (element-hq#28591) * [create-pull-request] automated change (element-hq#28600) Co-authored-by: t3chguy <[email protected]> * Improve coverage Signed-off-by: Michael Telatynski <[email protected]> * Update all non-major dependencies (element-hq#28556) * Update all non-major dependencies * Prettier Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <[email protected]> * Localazy Download (element-hq#28608) * [create-pull-request] automated change * Discard changes to src/i18n/strings/en_EN.json --------- Co-authored-by: t3chguy <[email protected]> Co-authored-by: Michael Telatynski <[email protected]> * Improve performance of RoomContext in RoomHeader (element-hq#28574) * Improve performance of RoomContext in RoomHeader This allows a component to subscribe to only part of the RoomContext so they do not need to re-render on every single change Signed-off-by: Michael Telatynski <[email protected]> * Update tests Signed-off-by: Michael Telatynski <[email protected]> * Prettier Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> * Add comment Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> * Replace `MatrixClient.isRoomEncrypted` by `MatrixClient.CryptoApi.isEncryptionEnabledInRoom` in `EventTile.tsx` (element-hq#28510) * Replace `MatrixClient.isRoomEncrypted` by `MatrixClient.CryptoApi.isEncryptionEnabledInRoom` in `EventTile.tsx` * Use `roomContext.isRoomEncrypted` * Improve coverage Signed-off-by: Michael Telatynski <[email protected]> * Fix release-checks to not use reserved name GITHUB_TOKEN Signed-off-by: Michael Telatynski <[email protected]> * Remove abandoned Voice Broadcasts labs flag (element-hq#28548) * Remove abandoned Voice Broadcasts labs flag Any existing voice broadcasts will be shown as a series of voice messages which will sequence play as normal Signed-off-by: Michael Telatynski <[email protected]> * Remove dead code Signed-off-by: Michael Telatynski <[email protected]> * Update snapshots Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> * Remove remaining reply fallbacks code (element-hq#28610) * Remove remaining reply fallbacks code as MSC2781 has been merged Signed-off-by: Michael Telatynski <[email protected]> * Update tests Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> * Provide a way to activate GIFs via the keyboard for a11y (element-hq#28611) * Provide a way to activate GIFs via the keyboard for a11y Signed-off-by: Michael Telatynski <[email protected]> * Remove dead code Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> * Fix code block highlighting not working reliably with many code blocks (element-hq#28613) Signed-off-by: Michael Telatynski <[email protected]> * Remove unused scripts (element-hq#28612) Signed-off-by: Michael Telatynski <[email protected]> * New UX for Share dialog (element-hq#28598) * New UX for `ShareDialog` * Use new named import * Rewrite tests * Add e2e tests * Use `box-sizing` for social buttons * Update e2e tests * [create-pull-request] automated change (element-hq#28621) Co-authored-by: t3chguy <[email protected]> * Reset matrix-js-sdk back to develop branch * Fix deploy script by normalizing version string Signed-off-by: Michael Telatynski <[email protected]> * Add `Close` tooltip to dialog (element-hq#28617) * Add `Close` tooltip to dialog * Update snapshots * Remove manual device verification which is not supported by the new cryptography stack (element-hq#28588) * Remove call of `MatrixClient.setDeviceVerified` * Replace usage of deprecated crypto events * Replace deprecated imports * Remove legacy button in `UntrustedDeviceDialog` * Review fixes * Add tests * Fix doc * Update js-sdk usages around Buffers to avoid needing Buffer polyfill Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> * Update test Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> * Iterate Signed-off-by: Michael Telatynski <[email protected]> * [create-pull-request] automated change (element-hq#28628) Co-authored-by: t3chguy <[email protected]> * Fix TAC `should mark all threads as read` e2e test (element-hq#28625) * Use specific import for bloom-filters to avoid Buffer dependency Signed-off-by: Michael Telatynski <[email protected]> * Tag screenshot tests to speed up test:playwright:screenshot (element-hq#28623) * Tag screenshot tests to speed up test:playwright:screenshot Signed-off-by: Michael Telatynski <[email protected]> * Add more tags Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> * Localazy Download (element-hq#28629) * [create-pull-request] automated change * Discard changes to src/i18n/strings/en_EN.json --------- Co-authored-by: t3chguy <[email protected]> Co-authored-by: Michael Telatynski <[email protected]> * Remove usages of Buffer Signed-off-by: Michael Telatynski <[email protected]> * Switch to using @fontsource for Inter & Inconsolata (element-hq#28540) * Switch to using @fontsource for Inter & Inconsolata Signed-off-by: Michael Telatynski <[email protected]> * Remove unused font Open_Sans Signed-off-by: Michael Telatynski <[email protected]> * Switch to less broken imports Signed-off-by: Michael Telatynski <[email protected]> * Switch to Ubuntu 24.04 Signed-off-by: Michael Telatynski <[email protected]> * Discard changes to res/themes/dark/css/dark.pcss * Discard changes to res/themes/legacy-light/css/_fonts.pcss * Discard changes to res/themes/light-high-contrast/css/light-high-contrast.pcss * Discard changes to res/themes/light/css/light.pcss * Discard changes to .github/workflows/end-to-end-tests.yaml * Set outputDir for fonts Signed-off-by: Michael Telatynski <[email protected]> * Use headed mode for Playwright Signed-off-by: Michael Telatynski <[email protected]> * Switch to new Chrome headless mode instead Signed-off-by: Michael Telatynski <[email protected]> * Cache bust playwright browser install in CI Signed-off-by: Michael Telatynski <[email protected]> * Update screenshots Signed-off-by: Michael Telatynski <[email protected]> * Try with 22.04 Signed-off-by: Michael Telatynski <[email protected]> * Update to Ubuntu Noble Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> * Fix font & spaces in settings subsection (element-hq#28631) * Fix settings header * Fix gap between subsection * Update tests * Update e2e tests * Update snapshots * increase ringing timeout from 10 seconds to 90 seconds (element-hq#28630) * increase ringing timeout from 10 seconds to 90 seconds * increase ringing timeout from 10 seconds to 90 seconds * increase max age of incoming notify event to 15 seconds which triggers a call ringingn notification/toast * Playwright: fix (hopefully) flaky shields test (element-hq#28641) * Playwright: improve failure report when an unexpected shield exists If we discover an E2E shield when we didn't expect one, let's make the error message more helpful by checking the tooltip. * Playwright: fix (hopefully) flaky shields test Wait for our user to fetch the bot's identity before running the test, to work around a race in the shield logic. Hopefully, fixes element-hq#28061 * [create-pull-request] automated change (element-hq#28646) Co-authored-by: t3chguy <[email protected]> * Switch to React18 useId (element-hq#28651) Signed-off-by: Michael Telatynski <[email protected]> * Add mergequeue tag to read-receipts tests and skip running them on PR commits (element-hq#28648) Signed-off-by: Michael Telatynski <[email protected]> * Remove stale webpack configuration (element-hq#28649) Signed-off-by: Michael Telatynski <[email protected]> * Fix multiple pinned messages flacky tests by waiting the message to be displayed in the banner when pinned. (element-hq#28655) * Notify to resize the timeline when the pinned message banner is displayed or hidden (element-hq#28654) * Update linkify to v4.2.0 (element-hq#28665) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * [create-pull-request] automated change (element-hq#28669) Co-authored-by: t3chguy <[email protected]> * Update CODEOWNERS * [create-pull-request] automated change (element-hq#28670) Co-authored-by: t3chguy <[email protected]> * Rename CreateCrossSigningDialog to InitialCryptoSetupDialog (element-hq#28658) * Rename CreateCrossSigningDialog to InitialCryptoSetup because it will soon encompass things other than just creating cross signing. * Fix name & tests * Fix import * Remove code creating key backup Because this was split out from my key backup by default PR * Fix comment * Convert to named export * Make tsc faster again (element-hq#28678) * Stash initial work to bring TSC from over 6 mins to under 1 minute Signed-off-by: Michael Telatynski <[email protected]> * Stabilise types Signed-off-by: Michael Telatynski <[email protected]> * Fix incorrect props to AccessibleButton Signed-off-by: Michael Telatynski <[email protected]> * Swap AccessibleButton element types to match the props they provide Signed-off-by: Michael Telatynski <[email protected]> * Changed my mind, remove spurious previously ignored props Signed-off-by: Michael Telatynski <[email protected]> * Update snapshots Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]> * Add delay in test to allow Alice to fetch Bob's device keys (element-hq#28668) * add delay in test to allow Alice to fetch Bob's device keys * wait until we see bob's device, rather than hard-coding a timeout * Fix comment Co-authored-by: Florian Duros <[email protected]> * fix lint --------- Co-authored-by: Florian Duros <[email protected]> * [create-pull-request] automated change (element-hq#28696) Co-authored-by: t3chguy <[email protected]> * Allow trusted Element Call widget to send and receive media encryption key to-device messages (element-hq#28316) * Upgrade dependency to [email protected] * v1.11.88-rc.0 * Upgrade dependency to [email protected] * v1.11.88 * Upgrade dependency to [email protected] * Fix url preview display (element-hq#28765) (element-hq#28766) (cherry picked from commit 117bee7) Co-authored-by: Florian Duros <[email protected]> * v1.11.89 --------- Signed-off-by: Michael Telatynski <[email protected]> Co-authored-by: Michael Telatynski <[email protected]> Co-authored-by: Hubert Chathi <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Florian Duros <[email protected]> Co-authored-by: ElementRobot <[email protected]> Co-authored-by: t3chguy <[email protected]> Co-authored-by: t3chguy <[email protected]> Co-authored-by: fkwp <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]> Co-authored-by: David Baker <[email protected]> Co-authored-by: Hugh Nimmo-Smith <[email protected]>
1 parent 6407be8 commit dde9c2c

File tree

699 files changed

+6534
-20050
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

699 files changed

+6534
-20050
lines changed

.eslintrc.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ module.exports = {
4242
name: "setImmediate",
4343
message: "Use setTimeout instead.",
4444
},
45+
{
46+
name: "Buffer",
47+
message: "Buffer is not available in the web.",
48+
},
4549
],
4650

4751
"import/no-duplicates": ["error"],
@@ -255,6 +259,9 @@ module.exports = {
255259
additionalTestBlockFunctions: ["beforeAll", "beforeEach", "oldBackendOnly"],
256260
},
257261
],
262+
263+
// These are fine in tests
264+
"no-restricted-globals": "off",
258265
},
259266
},
260267
{

CHANGELOG.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,38 @@
1+
Changes in [1.11.89](https://github.com/element-hq/element-web/releases/tag/v1.11.89) (2024-12-18)
2+
==================================================================================================
3+
This is a patch release to fix a bug which could prevent loading stored crypto state from storage, and also to fix URL previews when switching back to a room.
4+
5+
## 🐛 Bug Fixes
6+
7+
* Upgrade matrix-sdk-crypto-wasm to 1.11.0 (https://github.com/matrix-org/matrix-js-sdk/pull/4593)
8+
* Fix url preview display ([#28766](https://github.com/element-hq/element-web/pull/28766)).
9+
10+
11+
Changes in [1.11.88](https://github.com/element-hq/element-web/releases/tag/v1.11.88) (2024-12-17)
12+
==================================================================================================
13+
## ✨ Features
14+
15+
* Allow trusted Element Call widget to send and receive media encryption key to-device messages ([#28316](https://github.com/element-hq/element-web/pull/28316)). Contributed by @hughns.
16+
* increase ringing timeout from 10 seconds to 90 seconds ([#28630](https://github.com/element-hq/element-web/pull/28630)). Contributed by @fkwp.
17+
* Add `Close` tooltip to dialog ([#28617](https://github.com/element-hq/element-web/pull/28617)). Contributed by @florianduros.
18+
* New UX for Share dialog ([#28598](https://github.com/element-hq/element-web/pull/28598)). Contributed by @florianduros.
19+
* Improve performance of RoomContext in RoomHeader ([#28574](https://github.com/element-hq/element-web/pull/28574)). Contributed by @t3chguy.
20+
* Remove `Features.RustCrypto` flag ([#28582](https://github.com/element-hq/element-web/pull/28582)). Contributed by @florianduros.
21+
* Add Modernizr warning when running in non-secure context ([#28581](https://github.com/element-hq/element-web/pull/28581)). Contributed by @t3chguy.
22+
23+
## 🐛 Bug Fixes
24+
25+
* Fix jumpy timeline when the pinned message banner is displayed ([#28654](https://github.com/element-hq/element-web/pull/28654)). Contributed by @florianduros.
26+
* Fix font \& spaces in settings subsection ([#28631](https://github.com/element-hq/element-web/pull/28631)). Contributed by @florianduros.
27+
* Remove manual device verification which is not supported by the new cryptography stack ([#28588](https://github.com/element-hq/element-web/pull/28588)). Contributed by @florianduros.
28+
* Fix code block highlighting not working reliably with many code blocks ([#28613](https://github.com/element-hq/element-web/pull/28613)). Contributed by @t3chguy.
29+
* Remove remaining reply fallbacks code ([#28610](https://github.com/element-hq/element-web/pull/28610)). Contributed by @t3chguy.
30+
* Provide a way to activate GIFs via the keyboard for a11y ([#28611](https://github.com/element-hq/element-web/pull/28611)). Contributed by @t3chguy.
31+
* Fix format bar position ([#28591](https://github.com/element-hq/element-web/pull/28591)). Contributed by @florianduros.
32+
* Fix room taking long time to load ([#28579](https://github.com/element-hq/element-web/pull/28579)). Contributed by @florianduros.
33+
* Show the correct shield status in tooltip for more conditions ([#28476](https://github.com/element-hq/element-web/pull/28476)). Contributed by @uhoreg.
34+
35+
136
Changes in [1.11.87](https://github.com/element-hq/element-web/releases/tag/v1.11.87) (2024-12-03)
237
==================================================================================================
338
## ✨ Features

CONTRIBUTING.md

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -20,26 +20,26 @@ Definitely don't use the GitHub default of "Update file.ts".
2020

2121
As for your PR description, it should include these things:
2222

23-
- References to any bugs fixed by the change (in GitHub's `Fixes` notation)
24-
- Describe the why and what is changing in the PR description so it's easy for
25-
onlookers and reviewers to onboard and context switch. This information is
26-
also helpful when we come back to look at this in 6 months and ask "why did
27-
we do it like that?" we have a chance of finding out.
28-
- Why didn't it work before? Why does it work now? What use cases does it
29-
unlock?
30-
- If you find yourself adding information on how the code works or why you
31-
chose to do it the way you did, make sure this information is instead
32-
written as comments in the code itself.
33-
- Sometimes a PR can change considerably as it is developed. In this case,
34-
the description should be updated to reflect the most recent state of
35-
the PR. (It can be helpful to retain the old content under a suitable
36-
heading, for additional context.)
37-
- Include both **before** and **after** screenshots to easily compare and discuss
38-
what's changing.
39-
- Include a step-by-step testing strategy so that a reviewer can check out the
40-
code locally and easily get to the point of testing your change.
41-
- Add comments to the diff for the reviewer that might help them to understand
42-
why the change is necessary or how they might better understand and review it.
23+
- References to any bugs fixed by the change (in GitHub's `Fixes` notation)
24+
- Describe the why and what is changing in the PR description so it's easy for
25+
onlookers and reviewers to onboard and context switch. This information is
26+
also helpful when we come back to look at this in 6 months and ask "why did
27+
we do it like that?" we have a chance of finding out.
28+
- Why didn't it work before? Why does it work now? What use cases does it
29+
unlock?
30+
- If you find yourself adding information on how the code works or why you
31+
chose to do it the way you did, make sure this information is instead
32+
written as comments in the code itself.
33+
- Sometimes a PR can change considerably as it is developed. In this case,
34+
the description should be updated to reflect the most recent state of
35+
the PR. (It can be helpful to retain the old content under a suitable
36+
heading, for additional context.)
37+
- Include both **before** and **after** screenshots to easily compare and discuss
38+
what's changing.
39+
- Include a step-by-step testing strategy so that a reviewer can check out the
40+
code locally and easily get to the point of testing your change.
41+
- Add comments to the diff for the reviewer that might help them to understand
42+
why the change is necessary or how they might better understand and review it.
4343

4444
### Changelogs
4545

@@ -79,8 +79,8 @@ element-web notes: Fix a bug where the 'Herd' button only worked on Tuesdays
7979

8080
This example is for Element Web. You can specify:
8181

82-
- element-web
83-
- element-desktop
82+
- element-web
83+
- element-desktop
8484

8585
If your PR introduces a breaking change, use the `Notes` section in the same
8686
way, additionally adding the `X-Breaking-Change` label (see below). There's no need
@@ -96,10 +96,10 @@ Notes: Remove legacy `Camelopard` class. `Giraffe` should be used instead.
9696

9797
Other metadata can be added using labels.
9898

99-
- `X-Breaking-Change`: A breaking change - adding this label will mean the change causes a _major_ version bump.
100-
- `T-Enhancement`: A new feature - adding this label will mean the change causes a _minor_ version bump.
101-
- `T-Defect`: A bug fix (in either code or docs).
102-
- `T-Task`: No user-facing changes, eg. code comments, CI fixes, refactors or tests. Won't have a changelog entry unless you specify one.
99+
- `X-Breaking-Change`: A breaking change - adding this label will mean the change causes a _major_ version bump.
100+
- `T-Enhancement`: A new feature - adding this label will mean the change causes a _minor_ version bump.
101+
- `T-Defect`: A bug fix (in either code or docs).
102+
- `T-Task`: No user-facing changes, eg. code comments, CI fixes, refactors or tests. Won't have a changelog entry unless you specify one.
103103

104104
If you don't have permission to add labels, your PR reviewer(s) can work with you
105105
to add them: ask in the PR description or comments.

__mocks__/FontManager.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

code_style.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
This code style applies to projects which the element-web team directly maintains or is reasonably
44
adjacent to. As of writing, these are:
55

6-
- element-desktop
7-
- element-web
8-
- matrix-js-sdk
6+
- element-desktop
7+
- element-web
8+
- matrix-js-sdk
99

1010
Other projects might extend this code style for increased strictness. For example, matrix-events-sdk
1111
has stricter code organization to reduce the maintenance burden. These projects will declare their code

docs/SUMMARY.md

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,55 @@
11
# Summary
22

3-
- [Introduction](../README.md)
3+
- [Introduction](../README.md)
44

55
# Usage
66

7-
- [Betas](betas.md)
8-
- [Labs](labs.md)
7+
- [Betas](betas.md)
8+
- [Labs](labs.md)
99

1010
# Setup
1111

12-
- [Install](install.md)
13-
- [Config](config.md)
14-
- [Custom home page](custom-home.md)
15-
- [Kubernetes](kubernetes.md)
16-
- [Jitsi](jitsi.md)
17-
- [Encryption](e2ee.md)
12+
- [Install](install.md)
13+
- [Config](config.md)
14+
- [Custom home page](custom-home.md)
15+
- [Kubernetes](kubernetes.md)
16+
- [Jitsi](jitsi.md)
17+
- [Encryption](e2ee.md)
1818

1919
# Build
2020

21-
- [Customisations](customisations.md)
22-
- [Modules](modules.md)
23-
- [Native Node modules](native-node-modules.md)
21+
- [Customisations](customisations.md)
22+
- [Modules](modules.md)
23+
- [Native Node modules](native-node-modules.md)
2424

2525
# Contribution
2626

27-
- [Choosing an issue](choosing-an-issue.md)
28-
- [Translation](translating.md)
29-
- [Netlify builds](pr-previews.md)
30-
- [Code review](review.md)
27+
- [Choosing an issue](choosing-an-issue.md)
28+
- [Translation](translating.md)
29+
- [Netlify builds](pr-previews.md)
30+
- [Code review](review.md)
3131

3232
# Development
3333

34-
- [App load order](app-load.md)
35-
- [Translation](translating-dev.md)
36-
- [Theming](theming.md)
37-
- [Playwright end to end tests](playwright.md)
38-
- [Memory profiling](memory-profiles-and-leaks.md)
39-
- [Jitsi](jitsi-dev.md)
40-
- [Feature flags](feature-flags.md)
41-
- [OIDC and delegated authentication](oidc.md)
42-
- [Release Process](release.md)
34+
- [App load order](app-load.md)
35+
- [Translation](translating-dev.md)
36+
- [Theming](theming.md)
37+
- [Playwright end to end tests](playwright.md)
38+
- [Memory profiling](memory-profiles-and-leaks.md)
39+
- [Jitsi](jitsi-dev.md)
40+
- [Feature flags](feature-flags.md)
41+
- [OIDC and delegated authentication](oidc.md)
42+
- [Release Process](release.md)
4343

4444
# Deep dive
4545

46-
- [Skinning](skinning.md)
47-
- [Cider editor](ciderEditor.md)
48-
- [Iconography](icons.md)
49-
- [Jitsi](jitsi.md)
50-
- [Local echo](local-echo-dev.md)
51-
- [Media](media-handling.md)
52-
- [Room List Store](room-list-store.md)
53-
- [Scrolling](scrolling.md)
54-
- [Usercontent](usercontent.md)
55-
- [Widget layouts](widget-layouts.md)
46+
- [Skinning](skinning.md)
47+
- [Cider editor](ciderEditor.md)
48+
- [Iconography](icons.md)
49+
- [Jitsi](jitsi.md)
50+
- [Local echo](local-echo-dev.md)
51+
- [Media](media-handling.md)
52+
- [Room List Store](room-list-store.md)
53+
- [Scrolling](scrolling.md)
54+
- [Usercontent](usercontent.md)
55+
- [Widget layouts](widget-layouts.md)

docs/app-load.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,18 +61,18 @@ flowchart TD
6161

6262
Key:
6363

64-
- Parallelogram: async/await task
65-
- Box: sync task
66-
- Diamond: conditional branch
67-
- Circle: user interaction
68-
- Blue arrow: async task is allowed to settle but allowed to fail
69-
- Red arrow: async task success is asserted
64+
- Parallelogram: async/await task
65+
- Box: sync task
66+
- Diamond: conditional branch
67+
- Circle: user interaction
68+
- Blue arrow: async task is allowed to settle but allowed to fail
69+
- Red arrow: async task success is asserted
7070

7171
Notes:
7272

73-
- A task begins when all its dependencies (arrows going into it) are fulfilled.
74-
- The success of setting up rageshake is never asserted, element-web has a fallback path for running without IDB (and thus rageshake).
75-
- Everything is awaited to be settled before the Modernizr check, to allow it to make use of things like i18n if they are successful.
73+
- A task begins when all its dependencies (arrows going into it) are fulfilled.
74+
- The success of setting up rageshake is never asserted, element-web has a fallback path for running without IDB (and thus rageshake).
75+
- Everything is awaited to be settled before the Modernizr check, to allow it to make use of things like i18n if they are successful.
7676

7777
Underlying dependencies:
7878

docs/choosing-an-issue.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,19 @@ someone to add something.
3232
When you're looking through the list, here are some things that might make an
3333
issue a **GOOD** choice:
3434

35-
- It is a problem or feature you care about.
36-
- It concerns a type of code you know a little about.
37-
- You think you can understand what's needed.
38-
- It already has approval from Element Web's designers (look for comments from
39-
members of the
40-
[Product](https://github.com/orgs/element-hq/teams/product/members) or
41-
[Design](https://github.com/orgs/element-hq/teams/design/members) teams).
35+
- It is a problem or feature you care about.
36+
- It concerns a type of code you know a little about.
37+
- You think you can understand what's needed.
38+
- It already has approval from Element Web's designers (look for comments from
39+
members of the
40+
[Product](https://github.com/orgs/element-hq/teams/product/members) or
41+
[Design](https://github.com/orgs/element-hq/teams/design/members) teams).
4242

4343
Here are some things that might make it a **BAD** choice:
4444

45-
- You don't understand it (maybe add a comment asking a clarifying question).
46-
- It sounds difficult, or is part of a larger change you don't know about.
47-
- **It is tagged with `X-Needs-Design` or `X-Needs-Product`.**
45+
- You don't understand it (maybe add a comment asking a clarifying question).
46+
- It sounds difficult, or is part of a larger change you don't know about.
47+
- **It is tagged with `X-Needs-Design` or `X-Needs-Product`.**
4848

4949
**Element Web's Design and Product teams tend to be very busy**, so if you make
5050
changes that require approval from one of those teams, you will probably have

docs/config.md

Lines changed: 33 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ If you would like to use Scalar, the integration manager maintained by Element,
455455

456456
For widgets in general (from an integration manager or not) there is also:
457457

458-
- `default_widget_container_height`
458+
- `default_widget_container_height`
459459

460460
This controls the height that the top widget panel initially appears as and is the height in pixels, default 280.
461461

@@ -551,38 +551,38 @@ preferences.
551551

552552
Currently, the following UI feature flags are supported:
553553

554-
- `UIFeature.urlPreviews` - Whether URL previews are enabled across the entire application.
555-
- `UIFeature.feedback` - Whether prompts to supply feedback are shown.
556-
- `UIFeature.voip` - Whether or not VoIP is shown readily to the user. When disabled,
557-
Jitsi widgets will still work though they cannot easily be added.
558-
- `UIFeature.widgets` - Whether or not widgets will be shown.
559-
- `UIFeature.advancedSettings` - Whether or not sections titled "advanced" in room and
560-
user settings are shown to the user.
561-
- `UIFeature.shareQrCode` - Whether or not the QR code on the share room/event dialog
562-
is shown.
563-
- `UIFeature.shareSocial` - Whether or not the social icons on the share room/event dialog
564-
are shown.
565-
- `UIFeature.identityServer` - Whether or not functionality requiring an identity server
566-
is shown. When disabled, the user will not be able to interact with the identity
567-
server (sharing email addresses, 3PID invites, etc).
568-
- `UIFeature.thirdPartyId` - Whether or not UI relating to third party identifiers (3PIDs)
569-
is shown. Typically this is considered "contact information" on the homeserver, and is
570-
not directly related to the identity server.
571-
- `UIFeature.registration` - Whether or not the registration page is accessible. Typically
572-
useful if accounts are managed externally.
573-
- `UIFeature.passwordReset` - Whether or not the password reset page is accessible. Typically
574-
useful if accounts are managed externally.
575-
- `UIFeature.deactivate` - Whether or not the deactivate account button is accessible. Typically
576-
useful if accounts are managed externally.
577-
- `UIFeature.advancedEncryption` - Whether or not advanced encryption options are shown to the
578-
user.
579-
- `UIFeature.roomHistorySettings` - Whether or not the room history settings are shown to the user.
580-
This should only be used if the room history visibility options are managed by the server.
581-
- `UIFeature.TimelineEnableRelativeDates` - Display relative date separators (eg: 'Today', 'Yesterday') in the
582-
timeline for recent messages. When false day dates will be used.
583-
- `UIFeature.BulkUnverifiedSessionsReminder` - Display popup reminders to verify or remove unverified sessions. Defaults
584-
to true.
585-
- `UIFeature.locationSharing` - Whether or not location sharing menus will be shown.
554+
- `UIFeature.urlPreviews` - Whether URL previews are enabled across the entire application.
555+
- `UIFeature.feedback` - Whether prompts to supply feedback are shown.
556+
- `UIFeature.voip` - Whether or not VoIP is shown readily to the user. When disabled,
557+
Jitsi widgets will still work though they cannot easily be added.
558+
- `UIFeature.widgets` - Whether or not widgets will be shown.
559+
- `UIFeature.advancedSettings` - Whether or not sections titled "advanced" in room and
560+
user settings are shown to the user.
561+
- `UIFeature.shareQrCode` - Whether or not the QR code on the share room/event dialog
562+
is shown.
563+
- `UIFeature.shareSocial` - Whether or not the social icons on the share room/event dialog
564+
are shown.
565+
- `UIFeature.identityServer` - Whether or not functionality requiring an identity server
566+
is shown. When disabled, the user will not be able to interact with the identity
567+
server (sharing email addresses, 3PID invites, etc).
568+
- `UIFeature.thirdPartyId` - Whether or not UI relating to third party identifiers (3PIDs)
569+
is shown. Typically this is considered "contact information" on the homeserver, and is
570+
not directly related to the identity server.
571+
- `UIFeature.registration` - Whether or not the registration page is accessible. Typically
572+
useful if accounts are managed externally.
573+
- `UIFeature.passwordReset` - Whether or not the password reset page is accessible. Typically
574+
useful if accounts are managed externally.
575+
- `UIFeature.deactivate` - Whether or not the deactivate account button is accessible. Typically
576+
useful if accounts are managed externally.
577+
- `UIFeature.advancedEncryption` - Whether or not advanced encryption options are shown to the
578+
user.
579+
- `UIFeature.roomHistorySettings` - Whether or not the room history settings are shown to the user.
580+
This should only be used if the room history visibility options are managed by the server.
581+
- `UIFeature.TimelineEnableRelativeDates` - Display relative date separators (eg: 'Today', 'Yesterday') in the
582+
timeline for recent messages. When false day dates will be used.
583+
- `UIFeature.BulkUnverifiedSessionsReminder` - Display popup reminders to verify or remove unverified sessions. Defaults
584+
to true.
585+
- `UIFeature.locationSharing` - Whether or not location sharing menus will be shown.
586586

587587
## Undocumented / developer options
588588

@@ -592,4 +592,3 @@ The following are undocumented or intended for developer use only.
592592
2. `sync_timeline_limit`
593593
3. `dangerously_allow_unsafe_and_insecure_passwords`
594594
4. `latex_maths_delims`: An optional setting to override the default delimiters used for maths parsing. See https://github.com/matrix-org/matrix-react-sdk/pull/5939 for details. Only used when `feature_latex_maths` is enabled.
595-
5. `voice_broadcast.chunk_length`: Target chunk length in seconds for the Voice Broadcast feature currently under development.

0 commit comments

Comments
 (0)