fix(nsis): NSIS Uninstaller registry entry format change (#4069)

abhishekmatcha · develar · commit 7518aee8e1ab · 2019-07-23T09:11:17.000+02:00
diff --git a/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts b/packages/app-builder-lib/src/targets/nsis/NsisTarget.ts
@@ -167,7 +167,7 @@ export class NsisTarget extends Target {
       APP_PACKAGE_NAME: appInfo.name
     }
     if (uninstallAppKey !== guid) {
-      defines.UNINSTALL_REGISTRY_KEY_2 = `Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\${guid}`
+      defines.UNINSTALL_REGISTRY_KEY_2 = `Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{${guid}}`
     }
 
     const commands: any = {
diff --git a/packages/app-builder-lib/templates/nsis/multiUser.nsh b/packages/app-builder-lib/templates/nsis/multiUser.nsh
@@ -6,7 +6,7 @@
 
 # allow user to define own custom
 !define /ifndef INSTALL_REGISTRY_KEY "Software\${APP_GUID}"
-!define /ifndef UNINSTALL_REGISTRY_KEY "Software\Microsoft\Windows\CurrentVersion\Uninstall\${UNINSTALL_APP_KEY}"
+!define /ifndef UNINSTALL_REGISTRY_KEY "Software\Microsoft\Windows\CurrentVersion\Uninstall\{${UNINSTALL_APP_KEY}}"
 
 # current Install Mode ("all" or "CurrentUser")
 Var installMode

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ export class NsisTarget extends Target {`
`167`	`167`	`APP_PACKAGE_NAME: appInfo.name`
`168`	`168`	`}`
`169`	`169`	`if (uninstallAppKey !== guid) {`
`170`		- defines.UNINSTALL_REGISTRY_KEY_2 = `Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\${guid}`
	`170`	+ defines.UNINSTALL_REGISTRY_KEY_2 = `Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\{${guid}}`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`const commands: any = {`