After upgrading to 24.13.2, Windows NSIS installer Failed to uninstall old application files when there is an app running

[zaichaopan-alianza]

• Electron-Builder Version: 24.13.2

• Node Version: 18.14.0

• Electron Version: 29.1.1
• Electron Type (current, beta, nightly): current

• Target: Windows

After upgrading to 24.13.2, when installing nsis installer when app is running, it shows below error "xxxx cannot be closed. Please close it manually and click Retry to continue"

Click Retry will keep showing the dialog again. When click Cancel, it shows "old application files cannot be uninstalled"

Versions before 24.13.2 do not have this issue

When try previous version 24.13.1, It shows dialog xxx is running, click OK to close. After click OK, running app will close and install will continue.

Step to reproduce

• upgrade electron-builder to 24.13.2 and create a NSIS installer
• install the installer and have the app running
• click the installer again to install or make another new installer to install

Seems like the fix in #8059 introduce this issue. Have anyone run into the same issue?

Thx a million !

[mmaietta]

What's your nsis electron-builder config? I'll try and repro this locally

[zaichaopan-alianza]

thank you so much @mmaietta I have the repo https://github.com/zaichaopan-alianza/electron-builder-24.13.2-nsis-installer you can try. It is from electron-quick-start. My config is very simple. It just

{
  "name": "electron-quick-start",
  "version": "1.0.0",
  "description": "A minimal Electron application",
  "main": "main.js",
  "build": {
    "appId": "com.example.electron-quick-start"
  },
  "scripts": {
    "start": "electron .",
    "pack": "electron-builder --dir",
    "dist": "electron-builder"
  },
  "repository": "https://github.com/electron/electron-quick-start",
  "keywords": [
    "Electron",
    "quick",
    "start",
    "tutorial",
    "demo"
  ],
  "author": "GitHub",
  "license": "CC0-1.0",
  "devDependencies": {
    "electron": "^29.1.1",
    "electron-builder": "24.13.2"
  }
}

[mmaietta]

Thanks for the repo! Really appreciate it.

Will take a look this week when I find some solid time outside of work

[beyondkmp]

SYSTEMROOT = "c:\windows", The path c:\windows contains special characters, so it needs to be enclosed in double quotes to work properly.

!define SYSTEMROOT "$%SYSTEMROOT%"
nsExec::Exec '"${SYSTEMROOT}\System32\cmd.exe" /c tasklist /FI "USERNAME eq %USERNAME%" /FI "IMAGENAME eq ${_FILE}" /FO csv | "${SYSTEMROOT}\System32\find.exe" "${_FILE}"'

[zaichaopan-alianza]

@beyondkmp I tried the fix #8133. The issue is no longer reproduced. Thanks a lot!

[mmaietta]

Releasing in 25.0.0-alpha.4

[sumeet-singh04]

Would this fix be backported to 24.13.3 ?

[mmaietta]

Unfortunately, AFAIK it's not possible to backport fixes to previous versions due to the @changesets CI/CD approach. It's only able to roll forward AFAICT. Happy to be disproved otherwise though!

[indutny-signal]

Was the fix for this released already?

[mmaietta]

@indutny-signal The fix that was implemented was released in 25.0.0-alpha.4

[indutny-signal]

I was hoping for a stable release, but currently fighting my way through upgrading to 25.0.0 😂 Universal builds appear to be a bit hosed.

[mmaietta]

@indutny-signal yeah, I plan on converting it to stable soon, I was just hoping for more adoption than the ~7% it currently is 😅

Can you open a new GH issue for the universal build issue you mention? That particularly confuses me.

[finnlaymfarmor]

Hi @mmaietta ,

We're currently running [email protected], and getting the same error. I've tried a number of different fixes across GH Issues, SO, and asking LLM's but nothing seems to be remedying. Any ideas?

[1007912932]

你好@mmaietta，

我们目前正在运行 [email protected]，但出现了同样的错误。我尝试了 GH 问题、SO 和咨询 LLM 等多种不同的修复方法，但似乎都无济于事。有什么想法吗？

大神，最后怎么处理的这个问题，可以贴下回复吗，万分感谢！

[beyondkmp]

@finnlaymfarmor @1007912932 Can you provide a minimal reproducible demo code?

[1007912932]

electron-builder哪个版本解决了吗，我看8133关闭了

[1007912932]

能加个微信沟通下吗？
我的微信号：luffy_is_fool

[LWD8]

降回22.14.13就可以了，升级electron-builder@25也不行

[cgarrovillo]

This issue needs to be reopened as it seems we have not come into a common conclusion that this is fixed @mmaietta