You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+2Lines changed: 2 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -70,6 +70,8 @@ Note that if the templates are modified, the only things to do is to restart And
70
70
71
71
For now, the Matrix SDK and the Element application are in the same project. So there is no specific thing to do, this project should compile without any special action.
72
72
73
+
See [docs/rust_crypto_integration.md](./docs/rust_crypto_integration.md#testing-with-a-local-rust-aar) for notes on building against a custom version of the Rust `matrix-sdk-crypto`.
74
+
73
75
## I want to help translating Element
74
76
75
77
If you want to fix an issue with an English string, please submit a PR.
Until the final migration to [rust crypto sdk](https://github.com/matrix-org/matrix-rust-components-kotlin), the Element Android project will support two
4
-
different SDK as a product flavor.
5
-
6
-
The `matrix-sdk-android` module is defining a new flavor dimension `crypto`, with two flavors `kotlinCrypto` and `rustCrypto`.
7
-
The crypto module cannot be changed at runtime, it's a build time configuration. The app supports migration from kotlinCrypto to rustCrypto but not the other
8
-
way around.
9
-
10
-
The code that is not shared between the flavors is located in dedicated source sets (`src/kotlinCrypto/`, `src/rustCrypto/`). Some tests are also extracted
11
-
in different source sets because they were accessing internal API and won't work with the rust crypto sdk.
12
-
13
-
## Noticeable changes
14
-
15
-
As a general rule, if you stick to the `kotlinCrypto` the app should behave as it was before the integration of favours.
16
-
There is a noticeable exception though:
17
-
In order to integrate the rust crypto several APIs had to be migrated from callback code to suspendable code. This change
18
-
impacted a lot the key verification engine (user and device verification), so this part has been refactored for `kotlinCrypto`. The UI is also impacted,
19
-
the verification flows now match the web experience.
20
-
21
-
TLDR; Verification UI and engine has been refactored.
3
+
Element Android [now](https://github.com/element-hq/element-android/pull/8656) only supports the [rust crypto SDK](https://github.com/matrix-org/matrix-rust-sdk/tree/main/crates/matrix-sdk-crypto).
22
4
23
5
## Testing with a local rust aar
24
6
25
-
In order to run a custom rust SDK branch you can follow the direction in the [bindings repository](https://github.com/matrix-org/matrix-rust-components-kotlin)
26
-
in order to build the `matrix-rust-sdk-crypto.aar`.
7
+
In order to run a custom rust SDK branch you can follow the directions in the
0 commit comments