Skip to content

Commit 577a6b7

Browse files
authored
Make SonarCloud happier (#23699)
1 parent 77d7598 commit 577a6b7

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/vector/index.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,16 @@ function checkBrowserFeatures() {
7777
const featureList = Object.keys(window.Modernizr);
7878

7979
let featureComplete = true;
80-
for (let i = 0; i < featureList.length; i++) {
81-
if (window.Modernizr[featureList[i]] === undefined) {
80+
for (const feature of featureList) {
81+
if (window.Modernizr[feature] === undefined) {
8282
logger.error(
8383
"Looked for feature '%s' but Modernizr has no results for this. " +
84-
"Has it been configured correctly?", featureList[i],
84+
"Has it been configured correctly?", feature,
8585
);
8686
return false;
8787
}
88-
if (window.Modernizr[featureList[i]] === false) {
89-
logger.error("Browser missing feature: '%s'", featureList[i]);
88+
if (window.Modernizr[feature] === false) {
89+
logger.error("Browser missing feature: '%s'", feature);
9090
// toggle flag rather than return early so we log all missing features rather than just the first.
9191
featureComplete = false;
9292
}

src/vector/jitsi/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ const setupCompleted = (async () => {
102102

103103
const handleAction = (
104104
action: WidgetApiAction,
105-
handler: (request: IWidgetApiRequestData) => void,
105+
handler: (request: IWidgetApiRequestData) => Promise<void>,
106106
): void => {
107107
widgetApi.on(`action:${action}`, async (ev: CustomEvent<IWidgetApiRequest>) => {
108108
ev.preventDefault();

0 commit comments

Comments
 (0)