Skip to content

Fix jest/valid-expect lints throughout the codebase #24709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weeman1337 opened this issue Mar 1, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11238
Closed

Fix jest/valid-expect lints throughout the codebase #24709

weeman1337 opened this issue Mar 1, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11238
Assignees
@t3chguy
Labels
A-Developer-Experience T-Task Tasks for the team like planning

Comments

@weeman1337
Copy link
Contributor

weeman1337 commented Mar 1, 2023 •
edited by MadLittleMods
Loading

This is a follow-up to matrix-org/matrix-react-sdk#10261, sister issue tracking the same thing in the matrix-js-sdk repo,

There are too many flawed tests which violate jest/valid-expect and don't pass by simply adding await to the assertions (they require more http mocking, etc). We should fix up these scenarios as they are probably masking some failure cases.

The rule is currently disabled in .eslintrc.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Developer-Experience T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix jest/valid-expects lints matrix-org/matrix-react-sdk
3 participants
@t3chguy @weeman1337 @robintown