EW: Make identity reset consistent with EX

[mxandreas]

Background

Historically EW had many different identity resets, some of which only reset the cross-signing keys and some of which also reset "everything" (meaning any server-side copies of any keys as well as the server side storage as such). The other difference was that in some variants, EW also automatically asked user to set up recovery (on EX this step was separated from the reset flow).

To simplify it for the end users, and make it consistent with EX behavior, only one type of reset will be kept - the one that resets "everything" and does not set up recovery as part of it.

Problem

This new reset, including the new designs has been implemented for the scenarios:

• when the user goes proactively to Settings > Encryption > Advanced and triggers it.
• when user is notified that their key storage is out of sync, and the user chooses the Forgot recovery key option.

However, there are other scenarios which are not currently covered.

All of them have the same cause - the user needs to verify their device but is not able to - but the entry points in UI are several:

• The user tries to login.
• The user is already in the app but the device not verified:
  • Tries to access Settings > Encryption.
  • Tries to proactively verify the device (e.g. in the Sessions / Devices)
  • Gets a toast that prompts to verify the device.

Designs

• When reset is done during login.
• When reset is triggered when already in app.

Clarifications on the designs:

• All the current confirmation modals that currently appear right after clicking reset (there are a few variations depending on the starting point), should be removed. The very first screen is the one linked above (on the left are old, on the right the new design).

  • 

• Modernizing the screen that is used in case of OIDC (user is directed to MAS web app) is a stretch goal. The minimum is to make sure that the copy of the current modal follows the copy of new designs (current modal on the left, new designs on the right).

  • 

[uhoreg]

A couple questions:

When reset is triggered when already in app.

Is there a way of triggering reset other than in the Encryption settings tab?

The designs show a dialog that looks almost the same as the "Are you sure you want to reset your identity", but says "Reset your identity in case you can't confirm another way". When is this dialog triggered instead of the "Are you sure you want to reset your identity" dialog?

Notes to self:

• The "Are you sure you want to reset your identity" component is in components/views/settings/encryption/ResetIdentityPanel.tsx, but is built as a panel for the encryption settings and includes a breadcrumb at the top to return to the settings page so we'd need to separate out the common part and put it in a modal.

• The existing dialogs are in components/structures/auth/CompleteSecurity.tsx

[mxandreas]

Is there a way of triggering reset other than in the Encryption settings tab?

The other ways currently are:

• You get the "Key storage out of sync." toast, and decide to reset from there.
• Until we make verification mandatory at login, you can still trigger it when you go to verify your device from the Sessions tab (this will disappear of course soon, as we make verification mandatory).

Btw, I hoped the ticket description above makes this clear but let me know if there is anything confusing about it or it was just to confirm.

The designs show a dialog that looks almost the same as the "Are you sure you want to reset your identity", but says "Reset your identity in case you can't confirm another way". When is this dialog triggered instead of the "Are you sure you want to reset your identity" dialog?

If you meant this screen, then this is the (external) MAS confirmation modal. Its wording is tailored to the "I need to reset because I can't verify my device" scenario but I just checked that the same modal is re-used for the scenario when you proactively reset from Encryption tab.

@americanrefugee I think it is fine to keep it as it is for now because in 99% of cases people will do reset because they can't verify. We can always adjust this (e.g. make more generic so it fits all scenarios) later. In any case, it would not affect this story/ticket.

[uhoreg]

Components used by current dialogs:

components/structures/auth/SetupEncryptionBody, which is used by components/structures/auth/CompleteSecurity and
components/views/dialogs/security/SetupEncryptionDialog

components/views/dialogs/security/InitialCryptoSetupDialog, which is used by components/structures/auth/E2eSetup I think this is just for the initial setup, not for reset