Fix bug where StreamChangeCache would not respect cache factors (#17152)

erikjohnston · web-flow · commit 7c9ac01eb5fd · 2024-05-03T18:00:08.000+01:00
Annoyingly mypy didn't pick up this typo.
diff --git a/changelog.d/17152.bugfix b/changelog.d/17152.bugfix
@@ -0,0 +1 @@
+Fix bug where `StreamChangeCache` would not respect configured cache factors.
diff --git a/synapse/util/caches/stream_change_cache.py b/synapse/util/caches/stream_change_cache.py
@@ -115,7 +115,7 @@ def set_cache_factor(self, factor: float) -> bool:
         """
         new_size = math.floor(self._original_max_size * factor)
         if new_size != self._max_size:
-            self.max_size = new_size
+            self._max_size = new_size
             self._evict()
             return True
         return False

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix bug where `StreamChangeCache` would not respect configured cache factors.