Adds exit status code to Job (#45)

* Adds exit status code to Job

Signed-off-by: Tallys Martins <[email protected]>

* Fixes in seeds.exs scripts

- Make local calls to github in memory client to fetch config.yml
- Adds more jobs samples with different status, aka: success, failure and pending

Signed-off-by: Tallys Martins <[email protected]>

* Change status of existent jobs to success

Signed-off-by: Tallys Martins <[email protected]>

Author: tallysmartins

lib/elixir_bench/benchmarks/job.ex

@@ -15,6 +15,7 @@ defmodule ElixirBench.Benchmarks.Job do
     field :claimed_at, :utc_datetime
     field :completed_at, :utc_datetime
     field :log, :string
+    field :exit_status, :integer
 
     field :branch_name, :string
     field :commit_message, :string
@@ -41,7 +42,8 @@ defmodule ElixirBench.Benchmarks.Job do
     :cpu_count,
     # TODO: change to a string memory
     # :memory_mb,
-    :log
+    :log,
+    :exit_status
   ]
 
   @create_fields [

lib/elixir_bench_web/schema/content_types.ex

@@ -35,6 +35,7 @@ defmodule ElixirBenchWeb.Schema.ContentTypes do
     field :claimed_at, :datetime
     field :completed_at, :datetime
     field :log, :string
+    field :exit_status, :integer
 
     field :repo_slug, :string do
       resolve(fn %{repo_id: repo_id}, _, %{context: %{loader: loader}} ->

priv/repo/migrations/20180809140205_add_exit_status_to_job.exs

@@ -0,0 +1,14 @@
+defmodule ElixirBench.Repo.Migrations.AddExitStatusToJob do
+  use Ecto.Migration
+
+  def change do
+    alter table(:jobs) do
+      add :exit_status, :integer, default: nil
+    end
+
+    # assume all existent jobs has finished with success
+    execute """
+    UPDATE jobs SET exit_status = 0 WHERE exit_status IS NULL;
+    """, "" # nothing on down
+  end
+end

priv/repo/seeds.exs

@@ -1,11 +1,29 @@
 alias ElixirBench.{Benchmarks, Repos}
 
+github_client = Application.get_env(:elixir_bench, :github_client)
+
+if(github_client != ElixirBench.Github.ClientInMemory) do
+  raise """
+  \n
+  #############################################################################
+  Please, before running this seed you need to set :github_client to
+  ElixirBench.Github.ClientInMemory in your config/mix.#{Mix.env()}
+
+  This is necessary because our current scripts are not yet stable enough, so
+  you need to use local calls to mocked data instead of reaching the Github
+  servers in order to fetch the config.yml configuration for the repositories.
+  #############################################################################
+  """
+end
+
 {:ok, runner} = Benchmarks.create_runner(%{name: "test-runner", api_key: "test"})
 {:ok, repo} = Repos.create_repo(%{owner: "elixir-ecto", name: "ecto"})
 
-{:ok, %{id: job_id}} = Benchmarks.create_job(repo, %{branch_name: "mm/benches", commit_sha: "207b2a0"})
+{:ok, %{id: job_id1}} = Benchmarks.create_job(repo, %{branch_name: "mm/benches", commit_sha: "207b2a0"})
+{:ok, %{id: job_id2}} = Benchmarks.create_job(repo, %{branch_name: "mm/benches", commit_sha: "207b2a0"})
 
-{:ok, %{id: ^job_id} = job} = Benchmarks.claim_job(runner)
+{:ok, %{id: failed_job_id}} = Benchmarks.create_job(repo, %{branch_name: "mm/benches", commit_sha: "207b2a0"})
+{:ok, _pending_job} = Benchmarks.create_job(repo, %{branch_name: "mm/benches", commit_sha: "207b2a0"})
 
 data = %{
   "elixir_version" => "1.5.2",
@@ -17,6 +35,7 @@ data = %{
   "log" => """
   [now] Oh how ward it was to run this benchmark!
   """,
+  "exit_status" => 0,
   "measurements" => %{
     "insert_mysql/insert_plain" => %{
       "average" => 393.560253365004,
@@ -73,4 +92,11 @@ data = %{
   }
 }
 
-:ok = Benchmarks.submit_job(job, data)
+{:ok, %{id: ^job_id1} = job1} = Benchmarks.claim_job(runner)
+:ok = Benchmarks.submit_job(job1, data)
+
+{:ok, %{id: ^job_id2} = job2} = Benchmarks.claim_job(runner)
+:ok = Benchmarks.submit_job(job2, data)
+
+{:ok, %{id: ^failed_job_id} = failed_job} = Benchmarks.claim_job(runner)
+:ok = Benchmarks.submit_job(failed_job, %{data | "log" => "Error, exiting with status 127", "exit_status" => 127, "measurements" => nil})

test/elixir_bench_web/schema/schema_test.exs

@@ -394,18 +394,20 @@ defmodule ElixirBenchWeb.SchemaTest do
 
   describe "job query" do
     test "fetch job by id", context do
-      job = insert(:job)
+      job = insert(:job, %{exit_status: 1})
 
       query = """
         job (id: "#{job.id}") {
-          id
+          id,
+          exit_status
         }
       """
 
       json_data = %{
         "data" => %{
           "job" => %{
-            "id" => "#{job.id}"
+            "id" => "#{job.id}",
+            "exit_status" => 1
           }
         }
       }

test/support/factory/elixir_bench_factory.ex

@@ -106,6 +106,7 @@ defmodule ElixirBench.Factory do
       "log" => """
       [now] Oh how ward it was to run this benchmark!
       """,
+      "exit_status" => 0,
       "measurements" => %{
         "insert_mysql/insert_plain" => %{
           "average" => 393.560253365004,