install: Make elixir and otp versions required (#1779)

Author: wojtekmach

Diff for: install.bat

@@ -4,21 +4,17 @@ REM https://github.com/elixir-lang/elixir-lang.github.com/blob/main/install.bat
 
 setlocal EnableDelayedExpansion
 
-set "otp_version=latest"
-set "elixir_version=latest"
+set "otp_version="
+set "elixir_version="
 set "force=false"
 
 goto :main
 
 :usage
-echo Usage: install.bat [arguments] [options]
+echo Usage: install.bat elixir@ELIXIR_VERSION otp@OTP_VERSION [options]
 echo.
-echo Arguments:
-echo.
-echo   elixir@VERSION   Install specific Elixir version. The version can be X.Y.Z, latest, or main
-echo   otp@VERSION      Install specific Erlang/OTP version. The version can be X.Y.Z or latest
-echo.
-echo By default, elixir@latest and otp@latest are installed.
+echo ELIXIR_VERSION can be X.Y.Z, latest, or main.
+echo OTP_VERSION can be X.Y.Z or latest.
 echo.
 echo Options:
 echo.
@@ -27,9 +23,9 @@ echo   -h, --help       Prints this help
 echo.
 echo Examples:
 echo.
-echo   install.bat
 echo   install.bat [email protected] [email protected]
-echo   install.bat elixir@main
+echo   install.bat elixir@latest otp@latest
+echo   install.bat elixir@main otp@latest
 echo.
 goto :eof
 
@@ -57,6 +53,18 @@ for %%i in (%*) do (
   )
 )
 
+if "%elixir_version%" == "" (
+  call :usage
+  echo error: missing elixir@VERSION argument
+  exit /b 1
+)
+
+if "%otp_version%" == "" (
+  call :usage
+  echo error: missing otp@VERSION argument
+  exit /b 1
+)
+
 if "!otp_version!" == "latest" (
   set "url=https://github.com/erlef/otp_builds/releases/latest"
   for /f "tokens=2 delims= " %%a in ('curl -fsS --head "!url!" ^| findstr /I "^location:"') do set url=%%a

Diff for: install.sh

@@ -4,21 +4,16 @@
 
 set -eu
 
-otp_version=latest
-elixir_version=latest
+otp_version=
+elixir_version=
 force=false
 
 usage() {
   cat<<EOF
-Usage: install.sh [arguments] [options]
+Usage: install.sh elixir@ELIXIR_VERSION otp@OTP_VERSION [options]
 
-Arguments:
-
-  elixir@VERSION   Install specific Elixir version. The version can be X.Y.Z, latest, or main
-  otp@VERSION      Install specific Erlang/OTP version. The version can be X.Y.Z, latest,
-                   master, maint, or maint-RELEASE (e.g. maint-27)
-
-By default, elixir@latest and otp@latest are installed.
+ELIXIR_VERSION can be X.Y.Z, latest, or main.
+OTP_VERSION can be X.Y.Z, latest, master, maint, or maint-RELEASE (e.g. maint-27).
 
 Options:
 
@@ -27,13 +22,11 @@ Options:
 
 Examples:
 
-  sh install.sh
   sh install.sh [email protected] [email protected]
-  sh install.sh elixir@main
+  sh install.sh elixir@latest otp@latest
   sh install.sh elixir@main otp@master
 
 EOF
-  exit 0
 }
 
 main() {
@@ -47,6 +40,7 @@ main() {
         ;;
       -h|--help)
         usage
+        exit 0
         ;;
       -f|--force)
         force=true
@@ -58,6 +52,18 @@ main() {
     esac
   done
 
+  if [ -z "${elixir_version}" ]; then
+    usage
+    echo "error: missing elixir@VERSION argument"
+    exit 1
+  fi
+
+  if [ -z "${otp_version}" ]; then
+    usage
+    echo "error: missing otp@VERSION argument"
+    exit 1
+  fi
+
   root_dir="$HOME/.elixir-install"
   tmp_dir="$root_dir/tmp"
   mkdir -p "$tmp_dir"