Always pass -noshell when starting iex, fix Erlang/OTP 25

Author: josevalim

bin/elixir

@@ -218,7 +218,7 @@ SELF=$(readlink_f "$0")
 SCRIPT_PATH=$(dirname "$SELF")
 
 if [ "$OSTYPE" = "cygwin" ]; then SCRIPT_PATH=$(cygpath -m "$SCRIPT_PATH"); fi
-if [ "$MODE" != "iex" ]; then ERL="-noshell -s elixir start_cli $ERL"; fi
+if [ "$MODE" != "iex" ]; then ERL="-s elixir start_cli $ERL"; fi
 
 if [ "$OS" != "Windows_NT" ] && [ -z "$NO_COLOR" ]; then
   if test -t 1 -a -t 2; then ERL="-elixir ansi_enabled true $ERL"; fi
@@ -229,7 +229,7 @@ fi
 ERTS_BIN=
 ERTS_BIN="$ERTS_BIN"
 
-set -- "$ERTS_BIN$ERL_EXEC" -elixir_root "$SCRIPT_PATH"/../lib -pa "$SCRIPT_PATH"/../lib/elixir/ebin $ELIXIR_ERL_OPTIONS $ERL "$@"
+set -- "$ERTS_BIN$ERL_EXEC" -noshell -elixir_root "$SCRIPT_PATH"/../lib -pa "$SCRIPT_PATH"/../lib/elixir/ebin $ELIXIR_ERL_OPTIONS $ERL "$@"
 
 if [ -n "$RUN_ERL_PIPE" ]; then
   ESCAPED=""

bin/elixir.bat

@@ -162,10 +162,10 @@ if %errorlevel% == 0 (
   set beforeExtra=-elixir ansi_enabled true !beforeExtra!
 )
 if not defined useIEx (
-  set beforeExtra=-noshell -s elixir start_cli !beforeExtra!
+  set beforeExtra=-s elixir start_cli !beforeExtra!
 )
 
-set beforeExtra=-elixir_root "!SCRIPT_PATH!..\lib" -pa "!SCRIPT_PATH!..\lib\elixir\ebin" !beforeExtra!
+set beforeExtra=-noshell -elixir_root "!SCRIPT_PATH!..\lib" -pa "!SCRIPT_PATH!..\lib\elixir\ebin" !beforeExtra!
 
 if defined ELIXIR_CLI_DRY_RUN (
    if defined useWerl (

lib/iex/lib/iex/cli.ex

@@ -17,10 +17,17 @@ defmodule IEx.CLI do
 
       :user.start()
 
-      # IEx.Broker is capable of considering all groups under user_drv but
-      # when we use :user.start(), we need to explicitly register it instead.
-      # If we don't register, pry doesn't work.
-      :iex.start([register: true] ++ options(), {:elixir, :start_cli, []})
+      spawn(fn ->
+        :application.ensure_all_started(:iex)
+
+        case :init.notify_when_started(self()) do
+          :started -> :ok
+          _ -> :init.wait_until_started()
+        end
+
+        :ok = :io.setopts(binary: true, encoding: :unicode)
+        IEx.Server.run_from_shell([register: true] ++ options(), {:elixir, :start_cli, []})
+      end)
     end
   end