Deprecate ExUnit.after_spawn callbacks

Author: José Valim

Diff for: CHANGELOG.md

@@ -1,5 +1,6 @@
 * enhancements
   * [ExUnit] Tests can now receive metadata set on setup/teardown callbacks
+  * [ExUnit] Add support to ExUnit.CaseTemplate to share callbacks in between test cases
   * [IO] Add `IO.ANSI` to make it easy to write ANSI escape codes
   * [Kernel] Better support for Unicode lists
   * [Kernel] Reduce variables footprint in `case`/`receive` clauses

Diff for: lib/ex_unit/lib/ex_unit.ex

@@ -129,11 +129,10 @@ defmodule ExUnit do
     ExUnit.Server.merge_options(options)
   end
 
-  @doc """
-  Registers a callback to be invoked every time a
-  new ExUnit process is spawned.
-  """
+  @doc false
   def after_spawn(callback) do
+    IO.puts "ExUnit.after_spawn is deprecated, please use setup_all instead"
+    Exception.print_stacktrace
     ExUnit.Server.add_after_spawn(callback)
   end
 

Diff for: lib/ex_unit/test/ex_unit_test.exs

@@ -31,10 +31,6 @@ end
 defmodule ExUnitTest do
   use ExUnit.Case, async: false
 
-  test "it runs after_spawn hooks" do
-    assert Process.get(:after_spawn) == :ex_unit
-  end
-
   test "it can read user config" do
     File.write("ex_unit.test.config","[extra_option: true]")
     assert ExUnit.user_options("nosuchfile.config") == []

Diff for: lib/ex_unit/test/test_helper.exs

@@ -1,3 +1 @@
-# Configure ExUnit, no options supported yet.
 ExUnit.start []
-ExUnit.after_spawn fn -> Process.put(:after_spawn, :ex_unit) end

Diff for: lib/mix/test/test_helper.exs

@@ -47,23 +47,24 @@ Enum.each [:invalidapp, :invalidvsn, :noappfile, :ok], fn(dep) ->
 end
 
 defmodule MixTest.Case do
-  defmacro __using__(opts) do
+  use ExUnit.CaseTemplate
+
+  using do
     quote do
-      use ExUnit.Case, unquote(opts)
       import MixTest.Case
-
-      teardown do
-        Mix.env(:dev)
-        Mix.Task.clear
-        Mix.Shell.Process.flush
-        Mix.Deps.Converger.clear_cache
-        System.put_env("MIX_HOME", tmp_path(".mix"))
-        del_tmp_paths
-        :ok
-      end
     end
   end
 
+  teardown do
+    Mix.env(:dev)
+    Mix.Task.clear
+    Mix.Shell.Process.flush
+    Mix.Deps.Converger.clear_cache
+    System.put_env("MIX_HOME", tmp_path(".mix"))
+    del_tmp_paths
+    :ok
+  end
+
   def mix(args) do
     System.cmd "#{elixir_executable} #{mix_executable} #{args}"
   end