Warning on undefined types and callbacks in Erlang

Author: garazdawi

Diff for: lib/ex_doc/autolink.ex

@@ -413,7 +413,7 @@ defmodule ExDoc.Autolink do
       {:type, _visibility} ->
         case config.language.try_builtin_type(name, arity, mode, config, original_text) do
           nil ->
-            if mode == :custom_link do
+            if mode == :custom_link or config.language == ExDoc.Language.Erlang do
               maybe_warn(config, ref, visibility, %{original_text: original_text})
             end
 
@@ -482,7 +482,9 @@ defmodule ExDoc.Autolink do
 
         nil
 
-      {:regular_link, _module_visibility, :undefined} when not same_module? ->
+      {:regular_link, _module_visibility, :undefined}
+      when not same_module? and
+             (config.language != ExDoc.Language.Erlang or kind == :function) ->
         nil
 
       {_mode, _module_visibility, visibility} ->

Diff for: test/ex_doc/language/erlang_test.exs

@@ -382,6 +382,24 @@ defmodule ExDoc.Language.ErlangTest do
              ) =~ ~s|documentation references callback "c:erlang_bar:bad/0" but it is undefined|
     end
 
+    test "bad local type in module", c do
+      assert warn(
+               fn ->
+                 assert autolink_doc("\n`t:bad/0`", c) == ~s|<code class="inline">t:bad/0</code>|
+               end,
+               line: 2
+             ) =~ ~s|documentation references type "t:bad/0" but it is undefined or private|
+    end
+
+    test "bad local callback in module", c do
+      assert warn(
+               fn ->
+                 assert autolink_doc("\n`c:bad/0`", c) == ~s|<code class="inline">c:bad/0</code>|
+               end,
+               line: 2
+             ) =~ ~s|documentation references callback "c:bad/0" but it is undefined|
+    end
+
     test "bad function in module ref", c do
       assert warn(
                fn ->
@@ -448,6 +466,18 @@ defmodule ExDoc.Language.ErlangTest do
                ~s|<code class="inline">...a/0</code>|
     end
 
+    @tag warnings: :send
+    test "bad type", c do
+      assert warn(
+               fn ->
+                 assert autolink_extra("`t:bad:bad/0`", c) ==
+                          ~s|<code class="inline">t:bad:bad/0</code>|
+               end,
+               file: "extra.md",
+               line: 1
+             ) =~ ~s|documentation references type "t:bad:bad/0" but it is undefined or private|
+    end
+
     @tag warnings: :send
     test "bad type ref", c do
       assert warn(
@@ -460,6 +490,18 @@ defmodule ExDoc.Language.ErlangTest do
              ) =~ ~s|documentation references type "t:bad:bad/0" but it is undefined or private|
     end
 
+    @tag warnings: :send
+    test "bad callback", c do
+      assert warn(
+               fn ->
+                 assert autolink_extra("`c:bad:bad/0`", c) ==
+                          ~s|<code class="inline">c:bad:bad/0</code>|
+               end,
+               file: "extra.md",
+               line: 1
+             ) =~ ~s|documentation references callback "c:bad:bad/0" but it is undefined|
+    end
+
     test "bad module", c do
       assert autolink_extra("`does_not_exist`", c) ==
                ~s|<code class="inline">does_not_exist</code>|