Skip to content

Commit 8d9cf7c

Browse files
authored
Improve consistency of type rendering weight across OSes (#1677)
Use normal/400 instead of light/300 in the sidebar if the UA string indicates a non-Apple OS.
1 parent a07443e commit 8d9cf7c

File tree

5 files changed

+19
-0
lines changed

5 files changed

+19
-0
lines changed

assets/css/_html.css

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@import '@fontsource/lato/300.css';
2+
@import '@fontsource/lato/400.css';
23
@import '@fontsource/lato/700.css';
34
@import '@fontsource/merriweather/300.css';
45
@import '@fontsource/merriweather/300-italic.css';

assets/css/settings.css

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343

4444
#settings-modal-content .switch-button-container > div > p {
4545
font-size: 14px;
46+
font-weight: 300;
4647
line-height: 1.4;
4748
margin: 0;
4849
padding-bottom: 6px;

assets/css/sidebar.css

+9
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@
8080
line-height: 20px;
8181
color: var(--sidebarMuted);
8282
}
83+
.non-apple-os .sidebar .sidebar-projectVersion {
84+
font-weight: 400; /* Non-Apple OSes render small light type too thinly */
85+
}
8386

8487
.sidebar .sidebar-projectVersionsDropdown {
8588
cursor: pointer;
@@ -128,6 +131,9 @@
128131
font-size: 14px;
129132
color: var(--sidebarMuted);
130133
}
134+
.non-apple-os .sidebar .sidebar-listNav :is(li, li a) {
135+
font-weight: 400; /* Non-Apple OSes render small light type too thinly */
136+
}
131137

132138
.sidebar .sidebar-listNav li {
133139
display: inline-block;
@@ -359,6 +365,9 @@
359365
margin-right: 0;
360366
color: var(--sidebarAccentMain);
361367
}
368+
.non-apple-os .sidebar #full-list ul li {
369+
font-weight: 400; /* Non-Apple OSes render small light type too thinly */
370+
}
362371

363372
.sidebar #full-list ul li.current-hash {
364373
color: var(--sidebarActiveItem);

assets/js/entry/html.js

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import { initialize as initTooltips } from '../tooltips/tooltips'
1616
import { initialize as initHintsPage } from '../tooltips/hint-page'
1717
import { initialize as initCopyButton } from '../copy-button'
1818
import { initialize as initSettings } from '../settings'
19+
import { initialize as initOs } from '../os'
1920

2021
onDocumentReady(() => {
2122
initTheme()
@@ -33,4 +34,5 @@ onDocumentReady(() => {
3334
initSearchPage()
3435
initCopyButton()
3536
initSettings()
37+
initOs()
3638
})

assets/js/os.js

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
export function initialize () {
2+
const appleDeviceExpr = /(Macintosh|iPhone|iPad|iPod)/
3+
4+
const osClass = appleDeviceExpr.test(window.navigator.userAgent) ? 'apple-os' : 'non-apple-os'
5+
document.documentElement.classList.add(osClass)
6+
}

0 commit comments

Comments
 (0)