-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with swup and javascript #2081
Comments
@garazdawi we do support a new redirects option, would that work well: Line 162 in c2c994a
|
I had forgotten about those. I will try it. |
Yes, that works! Great! It seems a bit fragile though as essentially what happens is that original the |
@garazdawi alternatively we could support this:
Basically, if we have a redirect key, then we also generate the redirect page but keeping the sidebar link. Would that help? |
Would it not then just be better to have:
and have the link directly on the sidebar? Which is what I'm trying to achieve anyway. |
Yes, agreed. If you want to submit a PR, feel free, otherwise open up an issue and it will eventually be tackled. :) Just need to remember we should probably discard those for epub. :) |
Opened an issue. I will use my workaround for now, I'll try to get some time to work on a PR. |
In order to create links from the sidebar to other application I generate markdown files that look like this:
This no longer works as swup does not execute the javascript. I tried using the new
exdoc:loaded
:and while that works, the event is triggered rather late so that you can see the rendered page flicker by before the redirect happens.
Any suggestions on what I should do?
The text was updated successfully, but these errors were encountered: