Skip to content

Test lens doesn't escape test name properly #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
garthk opened this issue Feb 10, 2021 · 0 comments · Fixed by elixir-lsp/vscode-elixir-ls#175
Closed
2 tasks done

Test lens doesn't escape test name properly #485

garthk opened this issue Feb 10, 2021 · 0 comments · Fixed by elixir-lsp/vscode-elixir-ls#175

Comments

@garthk
Copy link

garthk commented Feb 10, 2021

If I click on the test lens for this test:

  test "decode!/2" do
    assert true
  end

… VS Code pops up a terminal window and tries to run mix test for just that test, without taking into account that an un-escaped exclamation mark outside single quotes will result in bash history expansion:

~/src/my_app$ mix test --exclude test --include "test:test decode!/2" /Users/garthk/src/my_app/test/my_app_test.exs
bash: !/2: event not found

Environment

  • Elixir & Erlang versions (elixir --version): Elixir 1.11.2 (compiled with Erlang/OTP 23)
  • Operating system: MacOS
  • Editor or IDE name: VS Code
  • Editor Plugin/LSP Client name: jakebecker.elixir-ls

Troubleshooting

  • Restart your editor (which will restart ElixirLS) sometimes fixes issues
  • Stop your editor, remove the entire .elixir_ls directory, then restart your editor

Logs

None relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant