refactor: get rid of DB.symbols/1

Author: dvic

lib/next_ls.ex

@@ -241,9 +241,33 @@ defmodule NextLS do
       end
     end
 
+    symbols = fn pid ->
+      rows =
+        DB.query(
+          pid,
+          ~Q"""
+          SELECT *
+          FROM symbols
+          WHERE source = 'user';
+          """,
+          []
+        )
+
+      for [_pk, module, file, type, name, line, column | _] <- rows do
+        %{
+          module: module,
+          file: file,
+          type: type,
+          name: name,
+          line: line,
+          column: column
+        }
+      end
+    end
+
     symbols =
       dispatch(lsp.assigns.registry, :databases, fn entries ->
-        for {pid, _} <- entries, symbol <- DB.symbols(pid), filter.(symbol.name) do
+        for {pid, _} <- entries, symbol <- symbols.(pid), filter.(symbol.name) do
           name =
             if symbol.type != "defstruct" do
               "#{symbol.type} #{symbol.name}"

lib/next_ls/db.ex

@@ -13,9 +13,6 @@ defmodule NextLS.DB do
   @spec query(pid(), query(), list()) :: list()
   def query(server, query, args \\ []), do: GenServer.call(server, {:query, query, args}, :infinity)
 
-  @spec symbols(pid()) :: list(map())
-  def symbols(server), do: GenServer.call(server, :symbols, :infinity)
-
   @spec insert_symbol(pid(), map()) :: :ok
   def insert_symbol(server, payload), do: GenServer.cast(server, {:insert_symbol, payload})
 
@@ -51,33 +48,6 @@ defmodule NextLS.DB do
     {:reply, rows, s}
   end
 
-  def handle_call(:symbols, _from, %{conn: conn} = s) do
-    rows =
-      __query__(
-        {conn, s.logger},
-        ~Q"""
-        SELECT *
-        FROM symbols
-        WHERE source = 'user';
-        """,
-        []
-      )
-
-    symbols =
-      for [_pk, module, file, type, name, line, column | _] <- rows do
-        %{
-          module: module,
-          file: file,
-          type: type,
-          name: name,
-          line: line,
-          column: column
-        }
-      end
-
-    {:reply, symbols, s}
-  end
-
   def handle_cast({:insert_symbol, symbol}, %{conn: conn} = s) do
     {:message_queue_len, count} = Process.info(self(), :message_queue_len)
     NextLS.DB.Activity.update(s.activity, count)