fixup! fixup! fixup! feat: RSS extension

Author: mhanberg

config/test.exs

@@ -3,3 +3,7 @@ import Config
 config :logger, level: :warning
 
 config :tableau, :config, url: "http://localhost:4999"
+config :tableau, Tableau.RSSExtension, enabled: false
+config :tableau, Tableau.PostExtension, enabled: false
+config :tableau, Mix.Tasks.Tableau.LogExtension, enabled: true
+config :tableau, Mix.Tasks.Tableau.FailExtension, enabled: true

lib/mix/tasks/tableau.build.ex

@@ -25,20 +25,28 @@ defmodule Mix.Tasks.Tableau.Build do
         token ->
           config_mod = Module.concat([module, Config])
 
-          {:ok, config} =
-            Application.get_env(:tableau, module, %{}) |> Map.new() |> config_mod.new()
+          raw_config =
+            Application.get_env(:tableau, module, %{}) |> Map.new()
 
-          {:ok, key} = Tableau.Extension.key(module)
+          if raw_config[:enabled] do
+            {:ok, config} =
+              raw_config
+              |> config_mod.new()
 
-          token = put_in(token[key], config)
+            {:ok, key} = Tableau.Extension.key(module)
 
-          case module.run(token) do
-            {:ok, token} ->
-              token
+            token = put_in(token[key], config)
 
-            :error ->
-              Logger.error("#{inspect(module)} failed to run")
-              token
+            case module.run(token) do
+              {:ok, token} ->
+                token
+
+              :error ->
+                Logger.error("#{inspect(module)} failed to run")
+                token
+            end
+          else
+            token
           end
       end
 
@@ -73,29 +81,36 @@ defmodule Mix.Tasks.Tableau.Build do
       token ->
         config_mod = Module.concat([module, Config])
 
-        {:ok, config} =
-          Application.get_env(:tableau, module, %{}) |> Map.new() |> config_mod.new()
+        raw_config =
+          Application.get_env(:tableau, module, %{}) |> Map.new()
+
+        if raw_config[:enabled] do
+          {:ok, config} =
+            raw_config
+            |> config_mod.new()
 
-        {:ok, key} = Tableau.Extension.key(module)
+          {:ok, key} = Tableau.Extension.key(module)
 
-        token = put_in(token[key], config)
+          token = put_in(token[key], config)
 
-        case module.run(token) do
-          {:ok, token} ->
-            token
+          case module.run(token) do
+            {:ok, token} ->
+              token
 
-          :error ->
-            Logger.error("#{inspect(module)} failed to run")
-            token
+            :error ->
+              Logger.error("#{inspect(module)} failed to run")
+              token
+          end
+        else
+          token
         end
     end
   end
 
   defp pre_build_extensions(modules) do
     for {mod, _, _} <- modules,
         mod = Module.concat([to_string(mod)]),
-        match?({:ok, :pre_build}, Tableau.Extension.type(mod)),
-        Tableau.Extension.enabled?(mod) do
+        match?({:ok, :pre_build}, Tableau.Extension.type(mod)) do
       mod
     end
     |> Enum.sort_by(& &1.__tableau_extension_priority__())
@@ -104,8 +119,7 @@ defmodule Mix.Tasks.Tableau.Build do
   defp post_write_extensions(modules) do
     for {mod, _, _} <- modules,
         mod = Module.concat([to_string(mod)]),
-        match?({:ok, :post_write}, Tableau.Extension.type(mod)),
-        Tableau.Extension.enabled?(mod) do
+        match?({:ok, :post_write}, Tableau.Extension.type(mod)) do
       mod
     end
     |> Enum.sort_by(& &1.__tableau_extension_priority__())

lib/tableau/extensions/post_extension.ex

@@ -83,7 +83,7 @@ defmodule Tableau.PostExtension do
 
   @config config
 
-  use Tableau.Extension, key: :posts, enabled: @config.enabled, type: :pre_build, priority: 100
+  use Tableau.Extension, key: :posts, type: :pre_build, priority: 100
 
   def run(token) do
     Module.create(