Skip to content

LSP server crashes when rename keeping the same name #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericdallo opened this issue Jul 4, 2020 · 1 comment
Closed

LSP server crashes when rename keeping the same name #41

ericdallo opened this issue Jul 4, 2020 · 1 comment

Comments

@ericdallo
Copy link
Member

Describe the bug
When renaming a symbol using lsp-rename and keeping the same name, the server crashes and lsp mode prints Server dart_analysis_server:23820 exited with status exit. Do you want to restart it? (y or n)

Version

[LSP Dart] 1.12.7 at 2020.07.04 @ Emacs 27.0.91
[Dart SDK] Dart VM version: 2.9.0-19.0.dev.flutter-7e72c9ae7e (be) (Fri Jun 19 18:05:23 2020 +0000) on "linux_x64"

lsp-log

[Trace - 04:36:07 PM] Sending request 'textDocument/prepareRename - (183)'.
Params: {
  "textDocument": {
    "uri": "file:///home/greg/dev/flutter_sample/lib/screens/dashboard/components/rightscreen.dart"
  },
  "position": {
    "line": 52,
    "character": 21
  }
}

[Trace - 04:36:07 PM] Received response 'textDocument/prepareRename - (183)' in 8ms.
Result: {
  "placeholder": "_goToNextPage",
  "range": {
    "end": {
      "character": 28,
      "line": 52
    },
    "start": {
      "character": 15,
      "line": 52
    }
  }
}

[Trace - 04:36:12 PM] Sending request 'textDocument/rename - (184)'.
Params: {
  "textDocument": {
    "uri": "file:///home/greg/dev/flutter_sample/lib/screens/dashboard/components/rightscreen.dart"
  },
  "position": {
    "line": 52,
    "character": 21
  },
  "newName": "_goToNextPage"
}

[Trace - 04:36:12 PM] Received response 'textDocument/rename - (184)' in 7ms.
Result: null
@ericdallo ericdallo changed the title LSP server crashes when renaming keeping the same name LSP server crashes when rename keeping the same name Jul 4, 2020
@ericdallo
Copy link
Member Author

Fixed on dart sdk: dart-lang/sdk#42573 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant